Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dprint config and commit-on-master task #66235

Merged
merged 63 commits into from
Oct 6, 2023

Conversation

JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 31, 2023

👉 See #65993 Using a formatter for formatting (instead of lint rules) for context.

Corresponds to the changes described in #65993. This initial PR adds:

  • .github/workflows/format-and-commit.yml: adds a workflow to run dprint and commit changes
    • Note that the trigger to run on master is commented out
  • .vscode/extensions.json: recommends the dprint extension
  • .vscode/settings.template.json: sets VS Code to format with the dprint extension by default
  • dprint.json: configuration file for dprint, including "excludes" for (known or seemingly) auto-generated packages
  • README.md docs around formatting
  • package.json: a new dev dependency on dprint

Because format-and-commit.yml's commit trigger is commented out, merging this PR won't cause dprint to be applied to all files.

Co-authored-by: @jakebailey

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Jul 31, 2023
dprint.json Outdated Show resolved Hide resolved
dprint.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member

Just as a meta-note about the workflows, I'd prefer if job configs were to come last; they get long and having them at the top will push info like the name/triggers/etc down to the bottom when it's usually important info. I don't think I've seen jobs stuck at the top before.

@typescript-bot
Copy link
Contributor

@sandersn, @jakebailey, @andrewbranch, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@jakebailey
Copy link
Member

#66235 (comment) shows the new dangerbot output.

@jakebailey
Copy link
Member

Okay, this PR should be ready to go, whenever we're ready to flip the switch! It'll immediately format about 141 files.

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 6, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Oct 6, 2023
@typescript-bot
Copy link
Contributor

@jakebailey, @sandersn, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@jakebailey
Copy link
Member

Ready to merge

@jakebailey
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants