-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dprint config and commit-on-master task #66235
Added dprint config and commit-on-master task #66235
Conversation
Just as a meta-note about the workflows, I'd prefer if job configs were to come last; they get long and having them at the top will push info like the name/triggers/etc down to the bottom when it's usually important info. I don't think I've seen jobs stuck at the top before. |
@sandersn, @jakebailey, @andrewbranch, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
#66235 (comment) shows the new dangerbot output. |
Okay, this PR should be ready to go, whenever we're ready to flip the switch! It'll immediately format about 141 files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
@jakebailey, @sandersn, @peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Ready to merge |
Corresponds to the changes described in #65993. This initial PR adds:
.github/workflows/format-and-commit.yml
: adds a workflow to run dprint and commit changesmaster
is commented out.vscode/extensions.json
: recommends the dprint extension.vscode/settings.template.json
: sets VS Code to format with the dprint extension by defaultdprint.json
: configuration file for dprint, including"excludes"
for (known or seemingly) auto-generated packagesREADME.md
docs around formattingpackage.json
: a new dev dependency ondprint
Becauseformat-and-commit.yml
's commit trigger is commented out, merging this PR won't causedprint
to be applied to all files.Co-authored-by: @jakebailey