-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatted types/a* packages with dprint #66238
Formatted types/a* packages with dprint #66238
Conversation
👋 @JoshuaKGoldberg! TypeScript repo itself uses double quotes: Prettier defaults to double quotes too (I know it’s not used, just giving some context). Given the above and the number of conversions from If you are interested in seeing opinions on pros and cons of each choice, here is a rather comprehensive discussion thread: prettier/prettier#4102 UPD: I created a thread for replies to avoid discussion mixing: #66238 (comment) |
|
just a bump, in case it got lost in other PRs |
Yes! Still on the radar. I touched up a good number of the open PRs this morning and all but two had existing/external failures. So I think I'm going to focus on fixing those up separately in parallel. |
Implements the dprint formatting changes packages whose names start with
a
. We're splitting up the changes to make it a bit easier to apply & review them en masse - and, if we need later on, revert / bisect for issues. These changes generated with roughly:CI failures are due to DefinitelyTyped-tools > feat: remove formatting rules rules from dtslint not being
mergedincluded in CI yet.Includes: