Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N°5619 - Hide newsroom menu when no provider #363

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

N°5619 - Hide newsroom menu when no provider #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12a58d1
N°5619 - hide newsroom menu when no provider
dflaven Nov 14, 2022
1982771
N°5619 - fixed crash when no provider at all!
dflaven Nov 17, 2022
c5640db
Cleanup: moved HasProvider() out of the Factory
dflaven Apr 6, 2023
a92c91d
PHPDoc
Molkobain Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions sources/application/UI/Base/Component/PopoverMenu/NewsroomMenu/NewsroomMenu.php
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@


use Combodo\iTop\Application\UI\Base\Component\PopoverMenu\PopoverMenu;
use MetaModel;

/**
* Class NewsroomMenu
Expand Down Expand Up @@ -65,4 +66,15 @@ public function GetParamsAsJson(): string
{
return json_encode($this->aParams);
}

/**
* Check if there is any Newsroom provider configured
* @since 3.1.0 N°5619
* @return bool
*/
public static function HasProviders(): bool
{
$aProviders = MetaModel::EnumPlugins('iNewsroomProvider');
return count($aProviders) > 0;
}
}
2 changes: 1 addition & 1 deletion sources/application/UI/Base/Layout/NavigationMenu/NavigationMenu.php
View file
Open in desktop
Expand Up @@ -269,7 +269,7 @@ public function GetSubBlocks(): array
*/
public function IsNewsroomEnabled(): bool
{
return MetaModel::GetConfig()->Get('newsroom_enabled');
return (MetaModel::GetConfig()->Get('newsroom_enabled') && NewsroomMenu::HasProviders());
}

/**
Expand Down
3 changes: 2 additions & 1 deletion sources/application/UI/Base/Layout/NavigationMenu/NavigationMenuFactory.php
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@


use ApplicationContext;
use Combodo\iTop\Application\UI\Base\Component\PopoverMenu\NewsroomMenu\NewsroomMenu;
use Combodo\iTop\Application\UI\Base\Component\PopoverMenu\NewsroomMenu\NewsroomMenuFactory;
use Combodo\iTop\Application\UI\Base\Component\PopoverMenu\PopoverMenuFactory;
use MetaModel;
Expand Down Expand Up @@ -48,7 +49,7 @@ public static function MakeStandard()
{

$oNewsroomMenu = null;
if (MetaModel::GetConfig()->Get('newsroom_enabled'))
if (MetaModel::GetConfig()->Get('newsroom_enabled') && NewsroomMenu::HasProviders())
{
$oNewsroomMenu = NewsroomMenuFactory::MakeNewsroomMenuForNavigationMenu();
}
Expand Down