N°5619 - Hide newsroom menu when no provider #363
Conversation
|
The second commit fixes a crash when there is actually no provider at all (not reproducible on a Community iTop, since there is the iTop Hub provider...) |
Molkobain
changed the title
sources/application/UI/Base/Component/PopoverMenu/NewsroomMenu/NewsroomMenuFactory.php
Outdated
Show resolved
Hide resolved
Molkobain
moved this from First review needed
to Pending technical review
in Combodo PR dashboard
| @@ -269,7 +270,7 @@ public function GetSubBlocks(): array | |||
| */ | |||
| public function IsNewsroomEnabled(): bool | |||
| { | |||
| return MetaModel::GetConfig()->Get('newsroom_enabled'); | |||
| return (MetaModel::GetConfig()->Get('newsroom_enabled') && NewsroomMenuFactory::HasProviders()); | |||
There was a problem hiding this comment.
But it does work on Essential/Professional products though, are you sure this is the root cause?
There was a problem hiding this comment.
According to #363 (comment) it's "crashing". Don't know what exactly he means with that.
There was a problem hiding this comment.
Without the second commit it was crashing (during the construction of the iTop WebPage) on Essential/Professional because the (empty) newsroom menu object was not created (because there is not newroom provider on such products).
There was a problem hiding this comment.
Discussed with Denis, I could not reproduce the issue on a Professional package. We would like to be able to reproduce the issue in order to ensure the fix is necessary and correct. Denis will dig further to have a reproduction procedure.
Molkobain
moved this from Pending technical review
to Pending contributor update
in Combodo PR dashboard
sources/application/UI/Base/Component/PopoverMenu/NewsroomMenu/NewsroomMenu.php
Outdated
Show resolved
Hide resolved
The newsroom menu can be hidden by configuration, but is not automatically hidden when there is no newsroom provider installed.
This pull request just hides the menu automatically in such a case.