tests: improve tests to make coverage 100% #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyaZar
force-pushed
the
fix-19
branch
2 times, most recently
from
df23cb1
to
18c8281
Compare
- add a test for the talkative feature on (talkative = TRUE)
- add tests for function on()
- test output class of the obsereEvent()
- test for errors i.e. when inits could not be found due to globally uninitialized event; check error messages specifically
- test for errors i.e. when inits could not be found due to session missmatch; check error messages specifically
- regroup tests for readability:
- a single test_that() for functions init/watch/trigger (with
talkative feature on/off)
- a single test_that() for on()
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19
For details the commit message but notably the current implementation does not check for #17, as only tests regarding the class are implemented so far.
So one might want to keep that in mind for a later update to the test files.
Otherwise on my machine: