Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3 #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix #3 #14

wants to merge 5 commits into from

Conversation

ilyaZar
Copy link
Contributor

@ilyaZar ilyaZar commented Mar 28, 2023 •
edited

Fix #3

Add several name-watchers for on()

  • provides the "or" case
  • provide an expression generator generate_watch_expr() that parses "name" arg to a list of reactives
  • each element of this list is put into observeEvent
  • if length(name) == 1, the default (previouis) behaviour is used

Restyle with grkstyler.

see edb8c82

@ilyaZar ilyaZar mentioned this pull request Mar 28, 2023
Open
@ilyaZar
Copy link
Contributor Author

ilyaZar commented Jul 4, 2023 •
edited

edit PR:

@ilyaZar
fix: add several name-watchers for on()
921c6eb 
- provides the "or" case for the components of the 'name' argument
- implementation: add an expression generator 'generate_watch_expr()':
    - if 'name' is a vector its elements are parsed to a list of reactives and put inside obeserveEvent()
    - if length(name) == 1, the default (previouis) behaviour is used
- style: run styler::style_file("R/funs.R", style = grkstyle::grk_style_transformer)
@ilyaZar
docs: updated for changes in on() function
311fc7b 
    - updated doc-string
    - change stop_if to stop_if_not (see changes to NAMESPACE as well)
    - add entry to roxygen which seems to be (?) necessary to make a link to a function in a different package via shiny::observeEvent
@ilyaZar
fix: pass 'session'-argument from on() to watch()
edb8c82 
- adding the session argument in view of ColinFay#17 and ColinFay#18
- remove redundant whitespace
@ilyaZar
feat: finer error msg. in on() for 'name' vector
f84c03d 
To make the error message more useful:
-> inisde stop_if_not(), the exact events/flags that have not been initiated are
printed
@ilyaZar
tests: add tests for feature 'name' vector in on()
e16ff21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using more than one 'name' argument for on()?
1 participant
@ilyaZar