Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to include file url #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SethFalco
Copy link

Adds the option to include a link to the references gitignore file in the README.
I prefer to add a link, so contributors know where it was derived from.

When the setting is enabled, the output looks like the following:

# https://raw.githubusercontent.com/github/gitignore/master/Maven.gitignore
target/
pom.xml.tag
pom.xml.releaseBackup
pom.xml.versionsBackup
pom.xml.next
release.properties
dependency-reduced-pom.xml
buildNumber.properties
.mvn/timing.properties
# https://github.com/takari/maven-wrapper#usage-without-binary-jar
.mvn/wrapper/maven-wrapper.jar

@CodeZombieCH
Copy link
Owner

I tought about this a few times as well, but I think your suggestion to make this optional is the best way to go.

@SethFalco
Copy link
Author

SethFalco commented Jul 12, 2022

Hey! Glad to see that you're alive! \(^-^)/

This weekend I can review all the ones you closed just to verify if they're cool, and fix the conflicts for the ones you've left open.
Thanks for peeking at the PRs!

@SethFalco SethFalco force-pushed the includeurl-option branch 2 times, most recently from 1166379 to 6a7ede8 Compare July 22, 2022 13:31
@SethFalco
Copy link
Author

SethFalco commented Jul 22, 2022

I've rebased with master.

I also added a new script to run tests in a headless environment. This will be useful later anyway if we set up GitHub Actions, but also just more convenient.

More Info: https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions

@SethFalco
Copy link
Author

I've rebased with master and resolved merge conflicts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants