Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: pull out strings in package.json #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SethFalco
Copy link

@SethFalco SethFalco commented Jul 11, 2021

This just pulls out some strings from the package.json file.

The name and description of the extension.
The names/descriptions of the configuration values.

This makes it easy to translate them for other users.

The value for the description property should be added to package.nls.json and then referenced in the package.json file for localization support.
- https://code.visualstudio.com/api/extension-guides/workspace-trust#static-declarations

I have another PR (#32) that will add a new setting if merged.
When/if this gets merged, I can change that to use the package.nls.json as well.

Translations can be added by creating package.nls.{lang}.json files, such as package.nls.fr.json for French, the rest is handled by Visual Studio Code automatically.


Could I also propose changing gitignore extension configuration to either (in order of how much I like them):

  • Git Ignore
  • Gitignore
  • gitignore

The "extension" part is redundant because it's already in the "extension" section.
And the "configuration" part is redundant because we're already in the VS Code settings.

image
You can see it looks a bit out of place there.

@SethFalco
Copy link
Author

Fixed conflicts, I also added a file here by accident that I was meant to do in a separate PR, but I guess it can stay. ^-^'

I wanted to add a CONTRIBUTING.md to just give a small intro on how to contribute to the repo, hope that's alright!

More Info: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors

@SethFalco
Copy link
Author

Rebased with master and resolved merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant