i18n: pull out strings in package.json #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just pulls out some strings from the
package.json
file.The name and description of the extension.
The names/descriptions of the configuration values.
This makes it easy to translate them for other users.
I have another PR (#32) that will add a new setting if merged.
When/if this gets merged, I can change that to use the
package.nls.json
as well.Translations can be added by creating
package.nls.{lang}.json
files, such aspackage.nls.fr.json
for French, the rest is handled by Visual Studio Code automatically.Could I also propose changing
gitignore extension configuration
to either (in order of how much I like them):The "extension" part is redundant because it's already in the "extension" section.
And the "configuration" part is redundant because we're already in the VS Code settings.
You can see it looks a bit out of place there.