Fix flaky tests 2 (stateless, integration)

[fm4v]

Changelog category (leave one):

• CI Fix or Improvement (changelog entry is not required)

Changes:

1. ClickHouseCluster.get_docker_handle() wait docker frequently and less time
2. integration tests: persist pdb history between test runs.
   Run pytest --pdb. On failure or breakpoint, it will fall back to PDB. Commands written here will be saved to a local file and loaded at the start of the next test run.
3. (attempt to) Fix some flaky integration and stateless tests

List of tests:

• tests/integration/test_backup_restore_on_cluster/test.py::test_different_tables_on_nodes
• tests/integration/test_global_overcommit_tracker/test.py::test_global_overcommit
• tests/integration/test_merges_memory_limit/test.py::test_memory_limit_success
• tests/integration/test_runtime_configurable_cache_size/test.py::test_query_cache_size_is_runtime_configurable
• tests/integration/test_dictionaries_update_and_reload/test.py::test_reload_after_fail_by_timer
• 0_stateless/01287_max_execution_speed.sql
• 01676_clickhouse_client_autocomplete.sh
• 03002_filter_skip_virtual_columns_with_non_deterministic_functions.sql

Failed reports is here

[tavplubix]

This is unreliable, it will remain flaky

[fm4v]

I actually break this test here in the last assert, sleep is required as i understand

        res = node.query_with_retry(
            "SELECT value FROM system.asynchronous_metrics WHERE metric = 'QueryCacheEntries'",
            check_callback=lambda result: result == "1\n",
        )
>       assert res == "1\n"
E       AssertionError: assert '2\n' == '1\n'
E         - 1
E         + 2

[rschu1ze]

I wrote this test originally and found this open PR by luck.

There were three recorded test failures in the past 6 months or so:

• https://s3.amazonaws.com/clickhouse-test-reports/57933/ca3ca8ffe403a26a1ff5bc77adb8895c89b16970/integration_tests__tsan__[1_6].html
• https://s3.amazonaws.com/clickhouse-test-reports/60211/c5d3aef83e287b477f67bb5b0e97ed534b567270/integration_tests__asan__analyzer__[1_6].html
• https://s3.amazonaws.com/clickhouse-test-reports/60497/cb8d8594533de3773ad1f30f7a5792f1e7e1bb39/integration_tests__tsan__[1_6].html

which is super sporadic given how many CI tests run per day.

In all cases, we ran three queries with query cache TTL = 1 sec, then wait 2 sec, and find that the query cache contains only 1 entry whereas 2 entries are expected. I can honestly not think of a scenario where this can happen except one: the asynchronous metrics are updated in a weird time interval that they report only 1 entry. Instead of adding retries (l. 105, please revert all retries from this file which only hide problems), please add SYSTEM RELOAD ASYNCHRONOUS METRICS before l. 106, see #53710. When I am back from vacation, I can add some documentation for SYSTEM RELOAD ASYNCHRONOUS METRICS.

[fm4v]

Retries are removed and SYSTEM RELOAD ASYNCHRONOUS METRICS after each wait. Lets pray it will be fixed

[robot-clickhouse-ci-2]

This is an automated comment for commit 0afd2e8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	⏳ pending
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	❌ failure
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[fm4v]

@tavplubix addition to original commits:

1. Add a test that compares parts after a database restore.
   tests/integration/test_backup_restore_on_cluster/test.py::test_replicated_database_compare_parts
2. Add fixture that persist pdb history to file
3. (attempt to) Fix tests/integration/test_dictionaries_update_and_reload/test.py::test_reload_after_fail_by_timer

[rschu1ze]

I wrote this test originally and found this open PR by luck.

There were three recorded test failures in the past 6 months or so:

• https://s3.amazonaws.com/clickhouse-test-reports/57933/ca3ca8ffe403a26a1ff5bc77adb8895c89b16970/integration_tests__tsan__[1_6].html
• https://s3.amazonaws.com/clickhouse-test-reports/60211/c5d3aef83e287b477f67bb5b0e97ed534b567270/integration_tests__asan__analyzer__[1_6].html
• https://s3.amazonaws.com/clickhouse-test-reports/60497/cb8d8594533de3773ad1f30f7a5792f1e7e1bb39/integration_tests__tsan__[1_6].html

which is super sporadic given how many CI tests run per day.

In all cases, we ran three queries with query cache TTL = 1 sec, then wait 2 sec, and find that the query cache contains only 1 entry whereas 2 entries are expected. I can honestly not think of a scenario where this can happen except one: the asynchronous metrics are updated in a weird time interval that they report only 1 entry. Instead of adding retries (l. 105, please revert all retries from this file which only hide problems), please add SYSTEM RELOAD ASYNCHRONOUS METRICS before l. 106, see #53710. When I am back from vacation, I can add some documentation for SYSTEM RELOAD ASYNCHRONOUS METRICS.