Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memo plotid #17856

Merged
merged 7 commits into from Apr 30, 2024
Merged

Fix memo plotid #17856

merged 7 commits into from Apr 30, 2024

Commits on Apr 9, 2024

  1. Convert hex to a string for memo and plotid

    @pmaslana
    pmaslana committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    89182c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Create a check for converting bytes to a string and remove the 32 byt… 

    …es check for memo and plotid args in create_plots.py
    @pmaslana
    pmaslana committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9975164 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Return the args.plotid bytes32.fromhex(plot_str) instead of bytes.fro… 

    …mhex(plot_str)
    @pmaslana
    pmaslana committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    08b202d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Remove debugging print that was used to print out the type

    @pmaslana
    pmaslana committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a68256a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Fix invalid type annotation

    @pmaslana
    pmaslana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9d5c3a4 View commit details
    Browse the repository at this point in the history

  2. Start using bytes32 for the type to prevent errors

    @pmaslana
    pmaslana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8c221a0 View commit details
    Browse the repository at this point in the history

  3. Change bytes32 to bytes

    @pmaslana
    pmaslana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    aa3b5c3 View commit details
    Browse the repository at this point in the history