Fix memo plotid #17856
Merged
Fix memo plotid #17856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es check for memo and plotid args in create_plots.py
emlowe
requested changes
Apr 12, 2024
There was a problem hiding this comment.
You also need to change the line
plot_memo: bytes32 = stream_plot_info_pk(keys.pool_public_key, keys.farmer_public_key, sk)
and remove the bytes32
plot_memo = stream_plot_info_pk(keys.pool_public_key, keys.farmer_public_key, sk)
I'm also not sure about the bytes or string check - might be better to also fix up the way chia plotters works instead - although this would work
emlowe
added
the
Fixed
|
If we fix earles comment we can get this PR in. |
|
emlowe
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fixes issues where "chia plotters" command is returning bytes and causing type issues. This also removed the bytes32 for the hex arg, which is 128 bytes.
Current Behavior:
New Behavior:
Testing Notes:
Created and duplicated plots using the plot ID and memo using "chia plots create" and "chia plotters chiapos"