Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fluids): Make local Vecs use PETSC_COMM_SELF in turbstats #1570

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Apr 29, 2024

This caused issues when using the spanwise statistics in parallel:

[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Invalid argument
[0]PETSC ERROR: Int value must be same on all processes, argument # 3
[0]PETSC ERROR: #1 VecSetSizes() at /lus/gecko/projects/PHASTA_aesp_CNDA/petsc-kjansen-fork1015002/src/vec/vec/interface/vector.c:1467
[0]PETSC ERROR: #2 CeedOperatorCreateLocalVecs() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/petsc_ops.c:326
[0]PETSC ERROR: #3 GetQuadratureCoords() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:169
[0]PETSC ERROR: #4 CreateStatsSF() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:262
[0]PETSC ERROR: #5 TurbulenceStatisticsSetup() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:494
[0]PETSC ERROR: #6 SetupLibceed() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/setuplibceed.c:413
[0]PETSC ERROR: #7 main() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/navierstokes.c:199

Also adds check in CeedOperatorCreateLocalVecs to verify that comm is of size 1.

Replaces #1569

Also adds check in CeedOperatorCreateLocalVecs to verify that comm is of
size 1.
@jrwrigh jrwrigh force-pushed the jrwrigh/fix_turbspanstats_comm branch from a4ce2e1 to 2788647 Compare April 29, 2024 00:42
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 29, 2024

IDK what's happening with the readthedocs CI job, but everything else is passing. Feel free to override and merge whenever.

@jedbrown
Copy link
Member

It passed, but somehow the result wasn't reported.

@jedbrown jedbrown merged commit 8452936 into main Apr 29, 2024
31 checks passed
@jedbrown jedbrown deleted the jrwrigh/fix_turbspanstats_comm branch April 29, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants