Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fluids): Remove comm arg from CeedOperatorCreateLocalVecs #1569

Closed
wants to merge 1 commit into from

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Apr 28, 2024

Vecs created this way should always be purely local and thus always use PETSC_COMM_SELF.

This caused issues when using the spanwise statistics in parallel:

[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Invalid argument
[0]PETSC ERROR: Int value must be same on all processes, argument # 3
[0]PETSC ERROR: #1 VecSetSizes() at /lus/gecko/projects/PHASTA_aesp_CNDA/petsc-kjansen-fork1015002/src/vec/vec/interface/vector.c:1467
[0]PETSC ERROR: #2 CeedOperatorCreateLocalVecs() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/petsc_ops.c:326
[0]PETSC ERROR: #3 GetQuadratureCoords() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:169
[0]PETSC ERROR: #4 CreateStatsSF() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:262
[0]PETSC ERROR: #5 TurbulenceStatisticsSetup() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/turb_spanstats.c:494
[0]PETSC ERROR: #6 SetupLibceed() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/src/setuplibceed.c:413
[0]PETSC ERROR: #7 main() at /lus/gecko/projects/PHASTA_aesp_CNDA/libCEED_1015002/examples/fluids/navierstokes.c:199

`Vec`s created this way should always be purely local and thus always
use `PETSC_COMM_SELF`.
@jedbrown
Copy link
Member

Communicators can have attributes, so there can be reason to use a communicator of size 1 that is not literally PETSC_COMM_SELF. VecCreateSeq still has a communicator argument, for example.

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 28, 2024

Ok. Do you think we should keep the comm argument then?

@jedbrown
Copy link
Member

That would be my preference, and check that the communicator size is 1.

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 29, 2024

Superseded by #1570

@jrwrigh jrwrigh closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants