Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 incorrect handling of computed property bindings #2473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

fix: 🐛 incorrect handling of computed property bindings

29ce61b
Select commit
Failed to load commit list.
Open

fix: 🐛 incorrect handling of computed property bindings #2473

fix: 🐛 incorrect handling of computed property bindings
29ce61b
Select commit
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Jul 19, 2023 in 31s

3 secrets uncovered!

3 secrets was uncovered from the scan of 1 commit in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #2473: pr-qwik 👉 main
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 29ce61b packages/sdks-tests/src/specs/input-disabled-binding.ts View secret
- Generic High Entropy Secret 29ce61b packages/sdks-tests/src/specs/input-disabled-binding.ts View secret
- Generic High Entropy Secret 29ce61b packages/sdks-tests/src/specs/input-disabled-binding.ts View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!