fix: 🐛 incorrect handling of computed property bindings #2473
Conversation
Computed properties/attributes were not applied to the rendering (only static values were applied) BREAKING CHANGE: 🧨 no
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 29ce61b | packages/sdks-tests/src/specs/input-disabled-binding.ts | View secret |
| - | Generic High Entropy Secret | 29ce61b | packages/sdks-tests/src/specs/input-disabled-binding.ts | View secret |
| - | Generic High Entropy Secret | 29ce61b | packages/sdks-tests/src/specs/input-disabled-binding.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
(undoing my approval after I noticed tests failing).
In fact, I'm surprised that even the gen1 react SDK fails on this test. Any ideas why? https://github.com/BuilderIO/builder/actions/runs/5602976068/jobs/10248953144?pr=2473
Computed properties/attributes were not applied to the rendering (only static values were applied)
BREAKING CHANGE: 🧨 no
Description
Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.
Screenshot
If relevant, add a screenshot or two of the changes you made.