SDK 2228 DMA Test automation #1377
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
- Coverage 51.10% 51.06% -0.04%
==========================================
Files 66 66
Lines 10158 10126 -32
Branches 3724 3712 -12
==========================================
- Hits 5191 5171 -20
+ Misses 4707 4701 -6
+ Partials 260 254 -6 ☔ View full report in Codecov by Sentry. |
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| #import "NSURLSessionBranch.h" | |||
There was a problem hiding this comment.
Swizzles are normally named like categories`NSURLSession+Branch.h". Not a blocking suggestion though.
|
@NidhiDixit09 |
| @@ -65,28 +71,37 @@ class HomeViewController: UITableViewController { | |||
| CommonMethod.sharedInstance.contentMetaData = nil | |||
| reachability = Reachability()! | |||
| reachability!.whenReachable = { reachability in | |||
|
|
|||
| Branch.setBranchKey("key_test_om2EWe1WBeBYmpz9Z1mdpopouDmoN72T") | |||
There was a problem hiding this comment.
Is this change to allow no tracking changes prior to first events?
| } else if textValue == "setDMAParams" { | ||
| self.logData = "Error: Missing testData.\n" | ||
|
|
||
| let storyBoard : UIStoryboard = UIStoryboard(name: "Main", bundle:nil) |
There was a problem hiding this comment.
Is it possible to move this logic into a helper method? It's kindof long.
| } else if textValue == "sendV2Event" { | ||
| self.logData = "" | ||
|
|
||
| let storyBoard : UIStoryboard = UIStoryboard(name: "Main", bundle:nil) |
There was a problem hiding this comment.
Similar request to move check logic into it's own method.
|
@NidhiDixit09 what's next for this PR? |
Reference
SDK-2228 -- DMA Compliance testing automation
https://branch.atlassian.net/browse/SDK-2228
Summary
Note : Ref is added to branch 'SDK-2228-iOS-DMA-Compliance-Automation' in workflow for testing purpose only. It will be reverted back before merging into master branch.
Type Of Change
Testing Instructions
Run workflow from this branch manually and verify in logs( or Browserstack) that Set DMA Params test passed.
cc @BranchMetrics/saas-sdk-devs for visibility.