Fix inconsistent icons in the app toolbar.

[flofriday]

Description

Closes: #7128
The problem was that the icons have their own color they use (attr/action_icon_color) which is fine, except in the toolbar where they should use a different color.

The fix applies a style to all toolbars where in the style only adds a theme for the surface which remaps the attr/action_icon_color to the color the other icons in the toolbar use.

Checklist

• I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
• I have performed a self-review of my code
• I have run the automated code checks using ./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug
• My code follows the style guidelines of the AntennaPod project: https://github.com/AntennaPod/AntennaPod/wiki/Code-style
• I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
• If it is a core feature, I have added automated tests

[ByteHamster]

Hmm, I think this looks a bit weird with the black title and gray icons. It also seems that many other apps with white toolbars (WhatsApp, Signal, Firefox, Tasks, Material Files, even the Android Settings app) use full-black action icons. I think we should switch the overflow menu icon to black instead of switching all other icons to gray.

[flofriday]

No problem, now that I know where the right knobs are it should be super easy to switch to that ;)

[flofriday]

I made them now vibrant.

I also discovered an issue with my solution which required me to remove the android:theme="?attr/actionBarTheme" from some screens. Removing that didn't have any visual impact and made my fix work on all screens. But maybe I don't know enough here and there was a good reason this was there.

Moreover I also discovered that the fix currently doesn't apply to the preferences, but I will look into that now.

Screenshots:

[flofriday]

I can't seem to figure out how to style the toolbar from the settings screen. It is a little bit difficult since we don't create it directly but PreferenceScreen creates it for us (at least I think that is what's happening).

[ByteHamster]

which required me to remove the android:theme="?attr/actionBarTheme" from some screens

This means style name="Widget.AntennaPod.ActionBar" is no longer applied to all toolbars. Not sure if that's a problem or if the style was just there for legacy reasons. The "blame" button on GitHub (or git blame) might give a cue why this style was added in the first place. We should also do some testing on devices/emulators with different Android versions and with/without the "dynamic colors" checkbox ticked.

I think we should be consistent across all screens, either removing the style completely or keeping it everywhere.

[flofriday]

I agree, about consitency. Tracking down the changes I found that in commit 7f4d43d you refactored the toolbar and added the theme as it wasn't there before.

However later we switched from androidx.appcompat.widget.Toolbar to com.google.android.material.appbar.MaterialToolbar in commit ac81143.
So maybe it was only needed for the old toolbar and the new one doesn't neeed it anymore.

Anyway, I will do some testing on older devices but so far I am leaning towards removing it everywhere. As for non dynamic themes, it looks great there and is quite similar to the dynamic themes which is why I didn't include it in the screenshots before. Maybe I should have explained that more.

[flofriday]

I just tested it on Android 5 (API 21) which is our lowest android target and the app still looks great. There are very few screens with an ugly toolbar but they are also there in on develop so my changes don't seem to destroy anything. 🎉

Screenshot of my changes:

Screenshot of the weired toolbar:
Again, this is also on develop and since android 5 is so old and the screen is bareley used I don't think we should put too much effort into it.

[ByteHamster]

Thanks!

I sneaked in a fix for the toolbar having a weird shadow :)

[flofriday]

@ByteHamster your fix also makes the toolbar in the settings page blue with elevation, which looks kinda odd as the statusbar is still white.

[ByteHamster]

Oops, thanks. Apparently I didn't test well enough. Fixed in #7169