Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent colors for top bar icons #7128

Open
4 tasks done
flofriday opened this issue Apr 21, 2024 · 6 comments
Open
4 tasks done

Inconsistent colors for top bar icons #7128

flofriday opened this issue Apr 21, 2024 · 6 comments
Labels
Type: Confirmed bug Bugs confirmed by a lead developer

Comments

@flofriday
Copy link
Contributor

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

App version

3.3.2f (develop branch)

Where did you get the app from

Google Play

Android version

14

Device model

Simulator (Pixel 8)

First occurred

At least since 2022 cause in the PR for Material You it is already measureable

Steps to reproduce

In my testing it is the most noticeable on dark mode with dynamic colors enabled (the material You color tinting). But once you see it it is difficult to unsee even on light themes.

To reproduce the worst offender:

  1. Switch to dark mode
  2. Enable dynamic colors
  3. Go to the information screen of any episode

Screenshot:
Screenshot 2024-04-21 at 18 27 44

Expected behaviour

All icons on the right have the same color.

Current behaviour

In many views the overflow menu and back arrow in the tool bar use a different color than other icons in the toolbar.

According to the spec, the icons on the right should all use the same color.

Logs

No response

@flofriday flofriday added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Apr 21, 2024
@keunes keunes added Type: Confirmed bug Bugs confirmed by a lead developer Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed and removed Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet labels Apr 21, 2024
@shaanrxx
Copy link

Hello, is it possible for me to work on this?

@flofriday
Copy link
Contributor Author

Go for it 😉

@shaanrxx
Copy link

Thanks! Do I need to be assigned?

@flofriday
Copy link
Contributor Author

No, but please read the contributor guidelines where such things are cleared up for you:
https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md

@shaanrxx
Copy link

Oh yes apologies, thank you!

@ByteHamster ByteHamster removed the Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed label Apr 24, 2024
@flofriday
Copy link
Contributor Author

@shaanrxx are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Confirmed bug Bugs confirmed by a lead developer
Projects
None yet
Development

No branches or pull requests

4 participants