Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "add podcast" FAB still visible under SpeedDial main FAB #6950

Merged
merged 1 commit into from Mar 17, 2024

Conversation

TacoTheDank
Copy link
Contributor

@TacoTheDank TacoTheDank commented Mar 2, 2024

Description

Taken from #6944.

Checklist

@ByteHamster
Copy link
Member

The setContentDescription part makes the app crash because it generates an endless loop. Apparently that is fixed by SpeedDialView 3.3.0. So we can basically decide if we want the content description to work (with 3.3.0) or focusing the correct menu item after opening to work (with 3.2.0). -.-

ERR: stack=java.lang.StackOverflowError: stack size 8MB
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   at com.leinardi.android.speeddial.SpeedDialView.setContentDescription(SpeedDialView.java:242)
   ...

@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Mar 7, 2024

@ByteHamster Lol, that's annoying. I would argue the crash fix is probably higher priority, as the focus issue is merely unintended behavior. If you want, maybe you can fork the library and revert the commit that causes leinardi/FloatingActionButtonSpeedDial#194, and we can use that fork until it's fixed upstream? The library repo isn't very active, so...

Or, you could take the other option and remove the library altogether: #6948.

@TacoTheDank TacoTheDank changed the title Two SpeedDial fixes Fix "add podcast" FAB still visible under SpeedDial main FAB Mar 17, 2024
@TacoTheDank
Copy link
Contributor Author

@ByteHamster How about this: I remove the setContentDescription change entirely and just make the PR about fixing the double FAB issue. That way at least the one fix can be merged :P

@ByteHamster ByteHamster merged commit 48c0ccb into AntennaPod:develop Mar 17, 2024
7 checks passed
@ByteHamster
Copy link
Member

Thanks!

@TacoTheDank TacoTheDank deleted the speedDialFixes branch March 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants