Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpeedDial library #6944

Closed
wants to merge 2 commits into from

Conversation

TacoTheDank
Copy link
Contributor

@TacoTheDank TacoTheDank commented Feb 27, 2024

Update FloatingActionButtonSpeedDial 3.2.0 -> 3.3.0 (changelog)

  • Fixes unintended behavior where "TalkBack's focus should be on the last item in the menu"
  • Not related to the library update itself, but I also fixed a separate bug where the "add podcast" FAB was still visible underneath the SpeedDial main FAB. It should be gone when the "multi select" option is active.
  • Note: Does NOT fix the SpeedDial main FAB being unlabeled in TalkBack. I've opened an issue for this.

Screenshots: Note the hidden FAB behind the SpeedDial FAB in the Before. Also note how the "Remove Podcast" button in the Before is darkened, while the one in After is not.

Before After
Screenshot_20240226-183911_AntennaPod Screenshot_20240226-183938_AntennaPod Debug

@ByteHamster
Copy link
Member

Unfortunately version 3.3.0 contains a regression for TalkBack users. Focusing one of the buttons worked in 3.2.0 but no longer works in 3.3.0. I reported this upstream: leinardi/FloatingActionButtonSpeedDial#194. I would prefer to not upgrade the library to a version that is affected by the regression. Every single time we upgrade dependencies, something gets broken... That's why I'm not a fan of upgrading dependencies unless it fixes a bug that we are affected by.

Your change to not show two FABs above each other looks like a good improvement. If you do it in a separate PR (or update this PR to not upgrade the dependency), it can be merged.

@TacoTheDank
Copy link
Contributor Author

@ByteHamster Done: #6950

@ByteHamster
Copy link
Member

Let's switch to another way of doing multi-select instead. See #6948.

@TacoTheDank TacoTheDank deleted the bumpSpeedDial branch March 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants