Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move multi-select actions from floating action button to top toolbar #6948

Closed
4 tasks done
ByteHamster opened this issue Mar 1, 2024 · 11 comments · Fixed by #7093
Closed
4 tasks done

Move multi-select actions from floating action button to top toolbar #6948

ByteHamster opened this issue Mar 1, 2024 · 11 comments · Fixed by #7093
Labels
Needs: Mock-up or user story Feature or enhancement request with an impact on the UI/UX, and needs mock-ups or user stories Type: Feature request

Comments

@ByteHamster
Copy link
Member

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.3.0

Where did you get the app from

Google Play

Problem you may be having, or feature you want

Almost all other apps that I tried show their multi-select actions in the top toolbar. AntennaPod shows them as an action button in the bottom. This is not intuitive for users (see https://forum.antennapod.org/t/merge-multi-select-and-long-press-menu-on-single-episode/2579/4). Another reason to switch is that the floating action button library caused quite a few problems in the past. Switching to the toolbar would allow removing the library.

Suggested solution

Use the top toolbar like other apps

Screenshots / Drawings / Technical details

No response

@ByteHamster ByteHamster added Type: Feature request Needs: Decision Proposal and most arguments are clear, but needs a verdict. labels Mar 1, 2024
@loucasal
Copy link
Contributor

loucasal commented Mar 2, 2024

Wouldn't the same argument (simplification, it's what other apps do) apply to the long-press menu? I have the impression that differentiating single-select and multi-select is the exception nowadays.

If the top bar is too crowded or hard to reach, there are examples of apps using a bottom sheet or bar (e.g. Google Photos uses a horizontally scrollable bottom sheet with fully labelled icons, which is overlaid on top of the bottom navigation).

@TacoTheDank
Copy link
Contributor

TacoTheDank commented Mar 2, 2024

I'm personally impartial to removing SpeedDial. I like the current speed dial multi-select actions, but I wouldn't be against switching to just using the top toolbar.

Obviously the users are going to be the ones you have to ask about this. I think this question should be asked on the AntennaPod forum for user feedback.

@ByteHamster
Copy link
Member Author

Wouldn't the same argument (simplification, it's what other apps do) apply to the long-press menu? I have the impression that differentiating single-select and multi-select is the exception nowadays.

Yes, that's one more reason to make it more standard compliant. Though I would start with multi-select for now because that's less intrusive. Changing the long-press menu will probably make some people not happy. Though I would say that most of the long-press options (except for maybe "move to top/bottom" in the queue) can be achieved with swipe actions anyway, so maybe it is okay if the options are a bit harder to reach.

@keunes
Copy link
Member

keunes commented Mar 7, 2024

I had a look at a bunch of apps on my phone where I can multi-select. Basically every app does it via the header bar, indicating the current selection number (not the total number of episodes. Some have 'selected', some only the number.

I like our FAB but cannot deny that the top bar is a common pattern. from the apps on my phone only Signal & FairEmail deviate from that pattern:
Imagepipe_1.jpg
Imagepipe_0.jpg

So I'm on board with this change. We just have to identify per screen which icons we'll put in the top bar, and which ones will be in the overflow.

@ByteHamster
Copy link
Member Author

I don't think we can show much more than just 2 icons by default. For these, I would use (consistently across all screens) the first single-select long-press actions "mark as played" and "add to queue" (because in the future, we might want to migrate single-select to always start multi-select).

@ByteHamster ByteHamster added Needs: Mock-up or user story Feature or enhancement request with an impact on the UI/UX, and needs mock-ups or user stories and removed Needs: Decision Proposal and most arguments are clear, but needs a verdict. labels Mar 17, 2024
@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/mark-all-newer-older-episodes-as-played-after-selected-one/4236/8

@keunes
Copy link
Member

keunes commented Apr 15, 2024

@ByteHamster IIRC two reasons for moving from the library to the overflow menu was maintainability and accessibility. Doesn't the in #7093 applied approach (Signal modal) have the same issues?

Plus with bottom navigation limited screen estate is left.

@ByteHamster
Copy link
Member Author

The accessibility should be better because it immediately tells the actions when jumping to the next container instead of just saying "unlabeled button". Also Discoverability for visually able users should be better. I have heard from a couple of users who didn't realize they need to click the "apply action" button to get to the actual multi-select actions. This way they are immediately visible.

Two advantages over the toolbar buttons:

  • Can show titles, so maybe a bit more clear than the toolbar icons (and fewer clicks than overflow items with title)
  • Closer to the finger

Plus with bottom navigation limited screen estate is left.

I think there is still quite a lot of screen space left, so that should be okay I guess.

@keunes
Copy link
Member

keunes commented Apr 28, 2024

Hi @VoidCrater,

We initially agreed to move the multi-select actions to the top app bar, but @ByteHamster preferred the way that Signal implemented multi-select. I must say I quite like it too.

We were wondering, though, if you would mind checking if this approach is easy to use in combination with TalkBack. Would you perhaps be willing to test that, and leave any feedback on any improvements desired on that front?

There is a 'debug' version from AntennaPod that you could download and install, in which this approach is already implemented:
AntennaPod-debug-multiselect-action.zip

Please let us know (also if you'd rather not receive such requests from you any longer).

@VoidCrater
Copy link

@keunes

We initially agreed to move the multi-select actions to the top app bar, but @ByteHamster preferred the way that Signal implemented multi-select. I must say I quite like it too.

I like this approach as well.

We were wondering, though, if you would mind checking if this approach is easy to use in combination with TalkBack. Would you perhaps be willing to test that, and leave any feedback on any improvements desired on that front?

Of course!
I installed and tested the debug version, and here are a few suggestions that I'd recommend:

  • I think it would be helpful to make TalkBack announce where the toolbar actions appear on the screen. As soon as the user enters selection mode, TalkBack could say something like "Toolbar actions shown at the bottom". This would let the TalkBack users know where the actions are located and won't have to explore the screen to find them. A good example of this implementation is Google Messages multi select behavior.
  • On the subscriptions, queue, downloads, playback history screens, when I enter selection mode and then perform the four finger swipe to get to the next container, TalkBack focuses on the first item in the bottom toolbar, however, this doesn't happen on the individual podcasts screen. Does this behavior have something to do with the issue material-components/material-components-android#3648?
    if not, then this is probably a bug that needs to be looked at.

Other than those suggestions, I think this implementation will work very well with TalkBack.

(also if you'd rather not receive such requests from you any longer).

I'm happy to contribute in any way possible. I'm also willing to test out features with TalkBack in the future :)

@ByteHamster
Copy link
Member Author

Thanks a lot for testing!

As soon as the user enters selection mode, TalkBack could say something like "Toolbar actions shown at the bottom".

Added.

TalkBack focuses on the first item in the bottom toolbar, however, this doesn't happen on the individual podcasts screen. Does this behavior have something to do with the issue material-components/material-components-android#3648?

Yes, I would guess that's the same issue :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Mock-up or user story Feature or enhancement request with an impact on the UI/UX, and needs mock-ups or user stories Type: Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants