New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move multi-select actions from floating action button to top toolbar #6948
Comments
Wouldn't the same argument (simplification, it's what other apps do) apply to the long-press menu? I have the impression that differentiating single-select and multi-select is the exception nowadays. If the top bar is too crowded or hard to reach, there are examples of apps using a bottom sheet or bar (e.g. Google Photos uses a horizontally scrollable bottom sheet with fully labelled icons, which is overlaid on top of the bottom navigation). |
I'm personally impartial to removing SpeedDial. I like the current speed dial multi-select actions, but I wouldn't be against switching to just using the top toolbar. Obviously the users are going to be the ones you have to ask about this. I think this question should be asked on the AntennaPod forum for user feedback. |
Yes, that's one more reason to make it more standard compliant. Though I would start with multi-select for now because that's less intrusive. Changing the long-press menu will probably make some people not happy. Though I would say that most of the long-press options (except for maybe "move to top/bottom" in the queue) can be achieved with swipe actions anyway, so maybe it is okay if the options are a bit harder to reach. |
I don't think we can show much more than just 2 icons by default. For these, I would use (consistently across all screens) the first single-select long-press actions "mark as played" and "add to queue" (because in the future, we might want to migrate single-select to always start multi-select). |
This issue has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/mark-all-newer-older-episodes-as-played-after-selected-one/4236/8 |
@ByteHamster IIRC two reasons for moving from the library to the overflow menu was maintainability and accessibility. Doesn't the in #7093 applied approach (Signal modal) have the same issues? Plus with bottom navigation limited screen estate is left. |
The accessibility should be better because it immediately tells the actions when jumping to the next container instead of just saying "unlabeled button". Also Discoverability for visually able users should be better. I have heard from a couple of users who didn't realize they need to click the "apply action" button to get to the actual multi-select actions. This way they are immediately visible. Two advantages over the toolbar buttons:
I think there is still quite a lot of screen space left, so that should be okay I guess. |
Hi @VoidCrater, We initially agreed to move the multi-select actions to the top app bar, but @ByteHamster preferred the way that Signal implemented multi-select. I must say I quite like it too. We were wondering, though, if you would mind checking if this approach is easy to use in combination with TalkBack. Would you perhaps be willing to test that, and leave any feedback on any improvements desired on that front? There is a 'debug' version from AntennaPod that you could download and install, in which this approach is already implemented: Please let us know (also if you'd rather not receive such requests from you any longer). |
I like this approach as well.
Of course!
Other than those suggestions, I think this implementation will work very well with TalkBack.
I'm happy to contribute in any way possible. I'm also willing to test out features with TalkBack in the future :) |
Thanks a lot for testing!
Added.
Yes, I would guess that's the same issue :/ |
Checklist
App version
3.3.0
Where did you get the app from
Google Play
Problem you may be having, or feature you want
Almost all other apps that I tried show their multi-select actions in the top toolbar. AntennaPod shows them as an action button in the bottom. This is not intuitive for users (see https://forum.antennapod.org/t/merge-multi-select-and-long-press-menu-on-single-episode/2579/4). Another reason to switch is that the floating action button library caused quite a few problems in the past. Switching to the toolbar would allow removing the library.
Suggested solution
Use the top toolbar like other apps
Screenshots / Drawings / Technical details
No response
The text was updated successfully, but these errors were encountered: