Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Persistent Client Identifier description to use IDENTIFYING_CLIENTS_LINK #6555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Persistent Client Identifier description to use IDENTIFYING_CLIENTS_LINK #6555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0abdce5
Add constant for IDENTIFYING_CLIENTS_LINK
PrplHaz4 Dec 18, 2023
a51b3f2
Update Client Identifier description to use IDENTIFYING_CLIENTS_LINK
PrplHaz4 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions client/src/components/Settings/Clients/Form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
renderTextareaField,
} from '../../../helpers/form';
import { validateClientId, validateRequiredValue } from '../../../helpers/validators';
import { CLIENT_ID_LINK, FORM_NAME, UINT32_RANGE } from '../../../helpers/constants';
import { IDENTIFYING_CLIENTS_LINK, FORM_NAME, UINT32_RANGE } from '../../../helpers/constants';
import './Service.css';

const settingsCheckboxes = [
Expand Down Expand Up @@ -98,12 +98,12 @@ const renderFieldsWrapper = (placeholder, buttonTitle) => function cell(row) {
))}
<button
type="button"
className="btn btn-link btn-block btn-sm"
className="btn btn- btn-block btn-sm"
onClick={() => fields.push()}
title={buttonTitle}
>
<svg className="icon icon--24">
<use xlinkHref="#plus" />
<use xHref="#plus" />
</svg>
</button>
</div>
Expand Down Expand Up @@ -298,7 +298,7 @@ let Form = (props) => {
title: 'upstream_dns',
component: <div label="upstream" title={props.t('upstream_dns')}>
<div className="form__desc mb-3">
<Trans components={[<a href="#dns" key="0">link</a>]}>
<Trans components={[<a href="#dns" key="0"></a>]}>
upstream_dns_client_desc
</Trans>
</div>
Expand Down Expand Up @@ -372,7 +372,7 @@ let Form = (props) => {
<div className="form__desc mt-0 mb-2">
<Trans components={[
<a target="_blank" rel="noopener noreferrer" href="https://github.com/AdguardTeam/AdGuardHome/wiki/Hosts-Blocklists#ctag"
key="0">link</a>,
key="0"></a>,
]}>
tags_desc
</Trans>
Expand All @@ -393,7 +393,7 @@ let Form = (props) => {
</div>
<div className="form__desc mt-0">
<Trans components={[
<a href={CLIENT_ID_LINK} target="_blank" rel="noopener noreferrer"
<a href={IDENTIFYING_CLIENTS_LINK} target="_blank" rel="noopener noreferrer"
key="0">text</a>,
]}>
client_identifier_desc
Expand Down
1 change: 1 addition & 0 deletions client/src/helpers/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export const REPOSITORY = {
};

export const CLIENT_ID_LINK = 'https://github.com/AdguardTeam/AdGuardHome/wiki/Clients#clientid';
export const IDENTIFYING_CLIENTS_LINK = 'https://github.com/AdguardTeam/AdGuardHome/wiki/Clients#idclient';
export const MANUAL_UPDATE_LINK = 'https://github.com/AdguardTeam/AdGuardHome/wiki/FAQ#manual-update';
export const PORT_53_FAQ_LINK = 'https://github.com/AdguardTeam/AdGuardHome/wiki/FAQ#bindinuse';
export const PRIVACY_POLICY_LINK = 'https://link.adtidy.org/forward.html?action=privacy&from=ui&app=home';
Expand Down