Update Persistent Client Identifier description to use IDENTIFYING_CLIENTS_LINK #6555
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add constant for IDENTIFYING_CLIENTS_LINK
Existing clientid link is too narrow for this general description, and skips over the whole part about MAC Address only being useful if AGH is also the DHCP Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple issues open and closed about the confusion around MAC only being a valid Client ID when AGH is also the DHCP Server. The existing clientid link is too narrow for this general description, and skips over the whole part about MAC Address only being useful if AGH is also the DHCP Server.
This PR adds a new constant that points the link on the Add Client page to the paragraph above ClientID, which addresses the other (Non-DOH) types of Client Identifiers.
References: