Fix/vote for delegate

[martiliones]

api.voteForDelegate()

• fix: validation for public keys and delegate names
• chore: better logging
• chore: updated example

[bludnic]

const result = await api.voteForDelegate('passphrase...', [
  '+U123456'
])

Actual:

Votes is +null

Expected:

Rejected if error if no public key

[bludnic]

Can you add a validation to check that the user is actually a Delegate? @martiliones
Voting for a regular user may result in a waste of ADM tokens.

[adamant-al]

Can you add a validation to check that the user is actually a Delegate? @martiliones Voting for a regular user may result in a waste of ADM tokens.

Do we want one more request?

[martiliones]

Do we want one more request?

Well, it can be done using the single request by retrieving all the delegates, since the amount of them is limited to 101, then find the delegate by address there. It doesn't cost much performance for a node since it does exactly the same under the hood for /delegates/get

It would be nice if we had /delegates/get endpoint optimized for finding a single delegate with addition of address parameter

[adamant-al]

It would be nice if we had /delegates/get endpoint optimized for finding a single delegate with addition of address parameter

You can create a Trello task for this and refer to the comment.