Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.4.0 #35

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

V2.4.0 #35

wants to merge 9 commits into from

Conversation

martiliones
Copy link
Member

No description provided.

@martiliones
Copy link
Member Author

waiting for Adamant-im/adamant-api-jsclient#57

@adamant-al
Copy link
Member

adamant-al commented Apr 24, 2024

npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: adamant-console@2.4.0
npm ERR! Found: eslint@9.1.1
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.1.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^7.32.0 || ^8.2.0" from eslint-config-airbnb-base@15.0.0
npm ERR! node_modules/eslint-config-airbnb-base
npm ERR!   dev eslint-config-airbnb-base@"^15.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

Will we do something with it?
Will it influence on npm install -g adamant-console?

pnpm install works well.

@adamant-al
Copy link
Member

> send message U15531909278942872097 "Hello"
{
  "success": true,
  "nodeTimestamp": 209573947,
  "transactionId": "9329817377467460348"
}

> get message 9329817377467460348
{
  "success": true,
  "nodeTimestamp": 209573956,
  "transaction": {
    "id": "9329817377467460348",
    "height": 40033196,
    "blockId": "9784287158004791648",
    "type": 8,
    "block_timestamp": 209573955,
    "timestamp": 209573947,
    "senderPublicKey": "bc3a58739dd875869e6fbda17776b90d30c1ccf59c317c45f0dbbbbfa67464af",
    "senderId": "U11682340443943600267",
    "recipientId": "U15531909278942872097",
    "recipientPublicKey": "fb736e72b4df38d973f0f8dfccbece763ab0d9603897dfa8f1167fa50018a8e0",
    "amount": 0,
    "fee": 100000,
    "signature": "4309ed9fa1fdf905fb8edc6dc353321f4fbfbb55ba716b7de009b0035692b1e0c71e6e78dd76818f422611fe776706a7a265b9b85e9fdbbb6c7ef14306e27601",
    "signatures": [],
    "confirmations": 1,
    "asset": {
      "chat": {
        "message": "Hello",
        "type": 1
      }
    }
  }
}

How do we know if transaction.asset.chat.message contains encrypted message or already decrypted?

@adamant-al
Copy link
Member

> send message U15531909278942872097 "Hello-ADM" 0.11ADM
{
  "success": true,
  "nodeTimestamp": 209574507,
  "transactionId": "5088544052328804510"
}

0 sec await

> get message 5088544052328804510
{
  "success": false,
  "error": "Not a message transaction"
}

Expected: Transaction not found.

@adamant-al
Copy link
Member

@martiliones
Is it possible not to downgrade eslint version?

@martiliones
Copy link
Member Author

@adamant-al
The eslint-config-airbnb-base plugin, which contains all the rules that the repository's style is based on, is not yet ready for eslint v9.

@martiliones
Copy link
Member Author

martiliones commented May 26, 2024

  • update docs for transaction.decoded in get message response

@adamant-al
Copy link
Member

@bludnic Check the PR.

@adamant-al
Copy link
Member

Release.

@adamant-al
Copy link
Member

@martiliones
Merge and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants