-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support native Apple ARM64 #461
Support native Apple ARM64 #461
Conversation
226de1e
to
e9c7a24
Compare
I'm not convinced that Am I missing something? |
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
f2265c6
to
e8a7e14
Compare
In my mind, there is a difference between cross-compiling and Rosetta since Rosetta is more an emulator/translator than a cross-compiler. For example, when you are building for iOS, you are not using Rosetta, you are using a cross-compiler. So at first, I treated the ARM64 the same way. So the question is whether we want to support cross-compilation or just native builds. If we want to support cross-compilation, CMAKE_OSX_ARCHITECTURES is the right choice, otherwise it is not needed. After discussion with @bernie-laberge about your comment @geffrak, we don't really see a use-case to support cross-compilation. So I removed the changed I did about CMAKE_OSX_ARCHITECTURES and we will just support native build. But like you said, you can still build for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow ! Beautiful and nice cleanup !
Thanks
e78d986
into
AcademySoftwareFoundation:main
This reverts commit e78d986.
This reverts commit e78d986. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Support native Apple ARM64
Linked issues
n/a
Summarize your change.
Supporting both x86_64 and arm64 native build. You can build x86_64 on MacOS if you run the build under a terminal launched with
arch -x86_64
(using Rosetta).I made changes to some dependencies under
cmake/dependencies
to standardized theconfigure
,command
andinstall
command used inexternalproject_add
since some dependencies were using a mix of CMake and Make command.Describe the reason for the change.
Support native build of Apple chipset.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.