[ 423: Non RHEL building ] #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithorus
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
Signed-off-by: Jimmy Christensen <lithorus@gmail.com>
Signed-off-by: Jimmy Christensen <lithorus@gmail.com>
Signed-off-by: Jimmy Christensen <lithorus@gmail.com>
Signed-off-by: Jimmy Christensen <lithorus@gmail.com>
lithorus
force-pushed
the
non-centos-build
branch
from
1bd8069
to
b03274f
Compare
bernie-laberge
approved these changes
May 27, 2024
geffrak
approved these changes
May 27, 2024
|
Thank you for checking in internal CI |
bernie-laberge
merged commit 9844fa4
into
AcademySoftwareFoundation:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #423
Summarize your change.
Have removed the blocking of trying to build on non-RHEL distro and changed to only use lib64 on RHEL distros.
Describe the reason for the change.
Unable to build on eg. Ubuntu
Describe what you have tested and on which operating system.
Have tested with Ubuntu 20.04 using a custom build of Qt5 (and rest is standard repo packages)
Add a list of changes, and note any that might need special attention during the review.
Have not (yet) tested on a RHEL distro, but have made changes that differentiate between RHEL and non-RHEL Linux distros