This repository has been archived by the owner on Mar 11, 2018. It is now read-only.
New arduino and camera code #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig for upwardTest.cpp ie upward motion client
…e its pid algorithm
… of bool_param in forwardTest.cpp ie forward motion client
…rd.cpp ie sideward motion server
…nged the pid to some extent
…the implementation of the flag variable as in dynamic reconfiguration
…previous imu comes in and also manual switching on of rosserial is possible without error
…cessing node and arduino node
…ore sending to arduino
…unctions in the header file
…nor errors in the existing class
…ctions in thruster.cpp, along with some minor changes
…o node with its functions defined in arduino_thrust.h file
…e the header files and their sources
|
@Mayankm96 please add this PR in the project code cleaning in hardware_layer .... and also please see the make of hardware_arduino package since some error is there in it |
|
This also solves #13 |
|
This PR consists of too many file changes. In general, a PR shouldn't have more than 5-6 file changes. It might take me a while to completely review the PR. |
|
As we discussed, each published sensor message should contain a header message as well. For the depth data, this is missing. You should create your custom message for this comprising of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the project regarding code cleaning in hardware_layer