Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding less-lethal. Mark all less-lethal rounds with less-lethal tag #1768

Merged
merged 7 commits into from
Sep 30, 2020

Conversation

emarcey
Copy link
Collaborator

@emarcey emarcey commented Sep 30, 2020

No description provided.

Copy link
Collaborator

@Murkantilism Murkantilism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +23 to 40
LESS_LETHALS = {
"bean-bag",
"foam-bullet",
"marking-round",
"tear-gas",
"pepper-spray",
"mace",
"paintball",
"pepper-ball",
"projectile",
"rubber-bullet",
"stun-grenade",
"taser",
"tear-gas",
"tear-gas-canister",
"wooden-bullet",
"lrad",
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we feel about a new enhancement Issue to collapse these tag-related lists & the possible_tags.md file into one?

Or even an Issue to autogenerate the possible_tags.md file for the Reporters to more easily read, yet keep the various tagging lists in 1 place/1 file.

Edit: I can write up this issue and try to implement once I'm done with zip-tie tagging, if we're interested

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've thought about it before and we probably should but I just haven't thought of a great way. but definitely a place we can improve

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emarcey just updated ticket #1775 to reflect this convo, gave it some direction/a goal. Will probably pause the zip ties work at some point soon and look at that issue, instead of waiting for completion, b/c I'm just about wrapping up California (this state took a while + I've been busy with other stuff).

@emarcey emarcey merged commit f0de31a into main Sep 30, 2020
@dostran4 dostran4 deleted the less-lethal branch October 1, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants