Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup JavaScript parsing #6583

Merged
merged 1 commit into from
May 31, 2024
Merged

refactor: cleanup JavaScript parsing #6583

merged 1 commit into from
May 31, 2024
+3,493 −1,579

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented May 20, 2024 •
edited

Summary

Followup #6598

  • Refactored DefinePlugin with string replacement
  • Supported more evaluation types to work with ConstPlugin
  • Supported asi safety check
  • Dropped swc codegen unit in parsing stage, removed run_before_pass

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels May 20, 2024
@h-a-n-a Graphite App
Copy link
Collaborator Author

h-a-n-a commented May 20, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on Graphite Graphite

@h-a-n-a h-a-n-a mentioned this pull request May 20, 2024
Merged
2 tasks
@h-a-n-a h-a-n-a force-pushed the 05-20-feat_defineplugin_ branch 5 times, most recently from 7017e11 to c8ef032 Compare May 21, 2024 10:21
@h-a-n-a h-a-n-a mentioned this pull request May 21, 2024
Merged
2 tasks
@h-a-n-a h-a-n-a mentioned this pull request May 21, 2024
Merged
2 tasks
Base automatically changed from fix/provide-plugin to main May 27, 2024 06:39
@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit ca80ec4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66597ba155050700085e5be7

@h-a-n-a h-a-n-a force-pushed the 05-20-feat_defineplugin_ branch 6 times, most recently from a58e6e6 to 20c87f4 Compare May 29, 2024 11:17
@h-a-n-a

This comment was marked as outdated.

Sign in to view
@h-a-n-a

This comment was marked as outdated.

Sign in to view
@rspack-bot

This comment was marked as outdated.

Sign in to view
@rspack-bot

This comment was marked as outdated.

Sign in to view
@rspack-bot

This comment was marked as outdated.

Sign in to view
@h-a-n-a

This comment was marked as outdated.

Sign in to view
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 31, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 31, 2024 •
edited

📝 Benchmark detail: Open

Name Base (2024-05-31 93a5923) Current Change
10000_development-mode + exec 2.61 s ± 25 ms 2.33 s ± 17 ms -10.64 %
10000_development-mode_hmr + exec 751 ms ± 7.8 ms 790 ms ± 8.3 ms +5.18 %
10000_production-mode + exec 2.56 s ± 31 ms 2.76 s ± 25 ms +7.69 %
arco-pro_development-mode + exec 2.41 s ± 66 ms 2.01 s ± 62 ms -16.70 %
arco-pro_development-mode_hmr + exec 482 ms ± 3.3 ms 480 ms ± 2.1 ms -0.54 %
arco-pro_production-mode + exec 3.99 s ± 72 ms 3.56 s ± 75 ms -10.81 %
threejs_development-mode_10x + exec 2.14 s ± 16 ms 1.35 s ± 19 ms -36.94 %
threejs_development-mode_10x_hmr + exec 957 ms ± 15 ms 810 ms ± 2.9 ms -15.40 %
threejs_production-mode_10x + exec 5.47 s ± 27 ms 4.67 s ± 20 ms -14.66 %

Threshold exceeded: ["10000_development-mode_hmr + exec","10000_production-mode + exec"]

@h-a-n-a h-a-n-a changed the title feat: DefinePlugin refactor: cleanup JavaScript parsing May 31, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label May 31, 2024
@h-a-n-a h-a-n-a marked this pull request as ready for review May 31, 2024 07:27
@h-a-n-a h-a-n-a enabled auto-merge (squash) May 31, 2024 07:50
@h-a-n-a h-a-n-a merged commit eaac36f into main May 31, 2024
32 checks passed
@h-a-n-a h-a-n-a deleted the 05-20-feat_defineplugin_ branch May 31, 2024 07:50
@h-a-n-a h-a-n-a restored the 05-20-feat_defineplugin_ branch May 31, 2024 10:48
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 31, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 31, 2024 •
edited

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ❌ failure
rsbuild ❌ failure
compat ✅ success
examples ✅ success

@h-a-n-a h-a-n-a deleted the 05-20-feat_defineplugin_ branch June 3, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees

@h-a-n-a h-a-n-a

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h-a-n-a @rspack-bot @LingyuCoder @ahabhgk