Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluation of ConstPlugin #6581

Merged

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented May 20, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link
Collaborator Author

h-a-n-a commented May 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @h-a-n-a and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels May 20, 2024
@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 9bf2858 to 3fe9eda Compare May 20, 2024 12:22
@h-a-n-a h-a-n-a changed the base branch from fix/provide-plugin to 05-20-feat_defineplugin_ May 20, 2024 12:22
@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 3fe9eda to 589cd5a Compare May 21, 2024 09:37
@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 589cd5a to 63f511f Compare May 21, 2024 09:41
@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 63f511f to 1ac6092 Compare May 21, 2024 09:45
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 21, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 21, 2024

📝 Benchmark detail: Open

task failure

@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 1ac6092 to 388c8ab Compare May 21, 2024 09:52
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented May 21, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented May 21, 2024

📝 Benchmark detail: Open

task failure

@h-a-n-a h-a-n-a force-pushed the 05-20-fix_evaluation_of_constplugin_ branch from 388c8ab to e8c418c Compare May 21, 2024 10:21
@h-a-n-a h-a-n-a marked this pull request as ready for review May 21, 2024 10:42
@h-a-n-a h-a-n-a merged commit 759493f into 05-20-feat_defineplugin_ May 21, 2024
23 of 26 checks passed
@h-a-n-a h-a-n-a deleted the 05-20-fix_evaluation_of_constplugin_ branch May 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants