Monster Loot Dropping Position #8347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a monster is killed, its first item will now always drop at the exact cell the monster was on - When a monster drops more than one item, the items will be deployed on 3 cells around the monster (looping): SE, W and N - Fixed monsters dropping items in reverse order - Fixes #8345
- Fixed item drop order - Fixed drop position of looted items - Fixed looted items showing special drop effects
- Searching for a free cell to drop an item on now uses the official algorithm - When a monster drops an item, it will no longer drop on cells that are occupied by characters or pets - When a player drops an item, it will now drop in a 5x5 area around the player - When an MVP drop drops to the floor because the player's inventory was full, it will now always drop on that player's cell
aleos89
reviewed
Jun 6, 2024
|
|
||
| for (int16 i = -1; i <= 1; i++) { | ||
| for (int16 j = -1; j <= 1; j++) { | ||
| if (i || j) |
There was a problem hiding this comment.
Your range is -1, 0, and 1 so this check will skip i == 0 and j == 0, is that correct?
There was a problem hiding this comment.
Yes, that's the intention of this check. If both are 0, it would always result in the center cell rather than a cell between distmin and distmax.
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request: