Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item drop location when killing a monster #8345

Closed
Playtester opened this issue May 20, 2024 · 3 comments · Fixed by #8347
Closed

Item drop location when killing a monster #8345

Playtester opened this issue May 20, 2024 · 3 comments · Fixed by #8347
Assignees
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode status:confirmed Issue that has been validated by a developer to affect rAthena type:bug Issue that is a bug within rAthena

Comments

@Playtester
Copy link
Member

rAthena Hash

c83f41a

Client Date

2021-11-03

Server Mode

Pre-Renewal

Result

When killing a monster its loot drops on random cell in a 3x3 area around it.

Relevant Log Output

No response

Expected Result

When killing a monster, its first regular drop will always drop at the exact cell the monster was on. It even drops there when the monster is inside Icewall.
After that each following drop drops in the following pattern: SE -> W -> N -> SE (it repeats, but never returns to center)
If those cells are occupied by walls (including Icewall), the item will drop in a 3x3 around that target cell instead (e.g. SE can become 2S).

How to Reproduce

Kill a monster that often drops items e.g CRYSTAL_1 (1395) or EVENT_RICECAKE (1815).
Try again with walls being near it.
Try again by blocking all target cells with Icewall.

Official Information

Can easily be verified through tests.

Modifications that may affect results

No response

@Playtester Playtester added status:confirmed Issue that has been validated by a developer to affect rAthena component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:bug Issue that is a bug within rAthena labels May 20, 2024
@Playtester Playtester self-assigned this May 20, 2024
Playtester added a commit that referenced this issue May 20, 2024
- When a monster is killed, its first item will now always drop at the exact cell the monster was on
- When a monster drops more than one item, the items will be deployed on 3 cells around the monster (looping): SE, W and N
- Fixed monsters dropping items in reverse order
- Fixes #8345
@idk-whoami
Copy link
Contributor

Is it possible to add the mob_loot do not show effect when drop into #8347

@Playtester
Copy link
Member Author

Playtester commented May 20, 2024

Is it possible to add the mob_loot do not show effect when drop into #8347

Currently no good way to differentiate between looted items and normal drops. That's why I reduced this issue also to normal drop behavior only and applied it to all. (In reality looted items actually start north.)

Edit: Good news! Looks like I found away to fix this at the same time.

@Playtester
Copy link
Member Author

Playtester commented May 22, 2024

Will check if the following things could be handled it one go or if a separate issue for them would be better:

  • Aegis has two item lists: Looted items and all other items (regular drops + item/skill granted drops)
  • Non-looted item lists drop item/skill granted drops first and the regular drops in their order from first to eight slot, the first item drops center
  • Looted items drop in the order they were looted, the first item drops north
  • Looted item drops are not showing a highlight (pillar)
  • Both lists proceed dropping in the same order after the first: SE -> W -> N -> SE
  • Items never drop on walls, icewalls and also not on CHAR|PET-occupied cells; if occupied, they drop on a free cell in a 3x3 area around the original target cell of the drop except for the center drop of a monster which will always drop there no matter what
  • If a player drops an item manually it will drop on a free cell in a 5x5 area around the player (random cell)
  • When searching for a random cell in both cases (3x3 or 5x5), the item will first try to drop in a random quadrant in that area without checking cells on the same x and y-axis, only if that fails, it will check the cells on the same x and y-axis as the original target cell
  • When searching for a random free cell completely fails, the item always drops at the original position, even if it is occupied

(Hint: If you surround yourself by icewalls so only the cell you are standing on does not have an icewall, then all items drop on the cell you are standing on.)

Playtester added a commit that referenced this issue Jun 7, 2024
- When a monster is killed, its first item will now always drop at the exact cell the monster was on
- When a monster drops more than one item, the items will be deployed on 3 cells around the monster (looping): SE, W and N
- Fixed drop position of looted items (similar to regular drops but independent to it and starts north)
- Fixed item drop order (script-granted -> regular drops -> looted drops)
- Fixed looted items showing special drop effects
- Searching for a free cell to drop an item on now uses the official algorithm
- When a monster drops an item, it will no longer drop on cells that are occupied by characters or pets
- When a player drops an item, it will now drop in a 5x5 area around the player
- Items dropped by players can now stack on the same cell unless the new "item_stacking" config is disabled
- When an MVP drop drops to the floor because the player's inventory was full, it will now always drop on that player's cell
- Fixes #8345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode status:confirmed Issue that has been validated by a developer to affect rAthena type:bug Issue that is a bug within rAthena
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants