Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Text with TMP_Text #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mchamplain
Copy link

@Tayx94
re-did the changes again in 2019.3.0 (not sure why but trying to import previous PR in 2019 messed up all the text positions, preferred starting from scratch)

Fresh install, new 3D Core project, TMP v2.0.1 is already installed.

Importing the package worked without issue, and when adding the prefab to the scene, Unity show the popup to install TMP essentials

Adding TMP to the dependencies in package.json make the package manager automatically install TMP at the same time and avoid errors.

@Tayx94
Copy link
Owner

Tayx94 commented Jul 25, 2022

Awesome, I'm travelling today, but I will probably be able to check it in the next few days 👍

@Tayx94
Copy link
Owner

Tayx94 commented Jul 26, 2022

Ok I checked and there are 2 main issues I've found.

  • Layout is not correct:

Unity_rs1FYR4q80

  • The original had a drop shadow behind it to improve readibility, but this one is just plain text
    image
    image

@mchamplain
Copy link
Author

hmmm, I tested on both 2019 and 2021 and the layout was fine,
this is in a new 2019 project? with TMP 2.0.1 also?

also, the font is configured with an underlay that is almost identical to the shadow you had. Was the roboto font picked up like supposed to or is it using the default TMP font? (Font/Roboto/Graphy_Roboto-Regular SDF.asset)

@Tayx94
Copy link
Owner

Tayx94 commented Aug 2, 2022

Sorry for the delay, I'm on holiday until next Monday, I'll take a look at it next week :)

I tested on a test project I have for Graphy, but I'll try on a new one just in case something broke because of it. Good that you took the underlay into account! I'll let you know next week about my findings

@ManuelRauber
Copy link
Contributor

Sorry for the delay, I'm on holiday until next Monday, I'll take a look at it next week :)

I tested on a test project I have for Graphy, but I'll try on a new one just in case something broke because of it. Good that you took the underlay into account! I'll let you know next week about my findings

Any news here for TMP? :)

@Tayx94
Copy link
Owner

Tayx94 commented Feb 16, 2023

Apologies, I'll try to check this on the weekend!

@ManuelRauber
Copy link
Contributor

Apologies, I'll try to check this on the weekend!

So :-) Any news here? 🙈
With Unity starting to deprecate the old text, it may be nice to start to switch to TMP.

@ManuelRauber
Copy link
Contributor

Apologies, I'll try to check this on the weekend!

After a looooong weekend now, any news? :-)

@Tayx94
Copy link
Owner

Tayx94 commented May 30, 2024

Long weekend indeed! Apologies for the delay. Life is busy at the moment so I can't dedicate time to non-critical issues. I share information on this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants