Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap all UI.Text for Text Mesh Pro to remove garbage generation. #93

Open
Tayx94 opened this issue May 8, 2022 · 4 comments
Open

Swap all UI.Text for Text Mesh Pro to remove garbage generation. #93

Tayx94 opened this issue May 8, 2022 · 4 comments
Labels
enhancement New improvement or request

Comments

@Tayx94
Copy link
Owner

Tayx94 commented May 8, 2022

No description provided.

@Tayx94 Tayx94 added the enhancement New improvement or request label May 8, 2022
@ManuelRauber
Copy link
Contributor

Hi @Tayx94!

It would be nice if Graphy could make use of TMP.

TMP is supposed to be supported in Unity 2019 which is what Graphy expects people to have at least.
But it does not ship as default yet (still not the case with Unity 2023 LTS), but requires two clicks to install it.

If you need help with it, let me know :)

@Tayx94
Copy link
Owner Author

Tayx94 commented May 30, 2024

Thank you for bringing interest into this @ManuelRauber! Ever since this MR has opened I've gotten very few people actually interested in this so priority hasn't been high.

I personally don't think it's a refactor worth doing at the moment. Some of the reasons why:

  • Text still hasn't been deprecated yet and it just works. "If it ain't broke, don't fix it".
  • No clear interest from the community.
  • Adding a dependency to TMP in package.json will make the package manager automatically install TMP for people that might not want TMP at all.
  • TMP adds no clear benefit to Graphy at the moment? I listed "remove garbage generation" but I'm not sure that's true. (Happy to be proven wrong here)
  • We don't know how the deprecation process for the old Text component will be. Maybe we can keep the current version of Graphy for Unity versions 2019-2023 and then make a new updated Graphy version for Unity 6+ that also leverages new features to maybe read new values and parameters.

As you can see there are lots of factors at play here.

Unless something changes here and we get more info it's probably not worth pursuing this yet, any work we do here might be wasted and need to be redone later on.

@ManuelRauber
Copy link
Contributor

Hi @Tayx94,

I understand! Thanks for your explanation.

If you need any help later when it comes to transit to TMP (or TextCore what it will be called), let me know. I'm happy to help! :)

@Tayx94
Copy link
Owner Author

Tayx94 commented May 30, 2024

Thank you @ManuelRauber ! I definitely will, once there is a more defined plan for this from Unity we can asses what to do 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New improvement or request
Projects
None yet
Development

No branches or pull requests

2 participants