x86: Add missing float-to-integer cast operation to CVTSD2SI/CVTSD2SI #6513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVTSS2SI/CVTSD2SI are instructions for converting scalar floating point values to integers.
In the SLEIGH spec, the float-to-integer cast operation (
trunc
) is missing in the constructors for handling the case where the size destination operand matches the floating point source operand size. (My guess is that the original author assumed that theround
operation performed the cast not thetrunc
op).e.g.:
f30f2dc0
"CVTSS2SI EAX, XMM0" with XMM0=0x41200000 (10.0)x86:LE:64:default
(Existing): { RAX = 0x41200000 }x86:LE:64:default
(This patch): { RAX = 0xa }