Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent land adjacencies with fire danger #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jruderman
Copy link
Contributor

Some of these are extremely dangerous (r'lyeh + rose). Most of them are at least somewhat dangerous and weird thematically.

@Quuxplusone
Copy link
Contributor

Quuxplusone commented Jul 10, 2021

I (think I) see what you mean about how if the Rose Garden catches fire, you probably just die. And I definitely think your patch cleans up the intent of the code very well. But... maybe the Dry Forest should be moved from the "catches fire" list to the "starts fires" list? Because:

  • Dry Forest does catch fire, but it's not catastrophic when it does, right? It's practically expected that it will.
  • I think it'd be pretty cool if you managed to start a fire in the Dry Forest by chaining from the Land of Power, so let's keep that coolness possible.
  • But it should be added to the other list, because a fire in the Rose Garden is equally dangerous no matter whether it's started by a Fire Cultist (R'lyeh) or a Fire Fairy (Dry Forest).

In other words, I think the lists should be "has any way to start fires" and "is especially unbalanced if it ever catches fire." The latter list wouldn't contain Dry Forest, and might not contain some other lands too, I dunno.

EDIT: I'm not sure there's any particular balance problem with the Vineyard catching fire, either.

@jruderman
Copy link
Contributor Author

Maybe the Dry Forest should be on both lists? Getting Dragon'd in the Dry Forest is a dangerous surprise, but having a Fire Fairy follow you into Yendorian Forest is also dangerous.

@emmiegit
Copy link
Contributor

I think it should be on both lists, it's both a source of fires and pretty radically changes when it catches fire (even if it's expected that it will).

@@ -248,17 +248,19 @@ EX int isRandland(eLand l) {
return 0;
}

EX bool landStartsFires(eLand l) {
return (l == laPower || l == laVolcano || l == laDragon || l == laEFire || l == laRlyeh);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in comments:

Suggested change
return (l == laPower || l == laVolcano || l == laDragon || l == laEFire || l == laRlyeh);
return (l == laPower || l == laVolcano || l == laDryForest || l == laDragon || l == laEFire || l == laRlyeh);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants