Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move land check functions to the top #213

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emmiegit
Copy link
Contributor

Minor PR that is a complement to #212.

It standardizes the function such that land check functions appear at the top rather than scattered throughout.

@jruderman
Copy link
Contributor

Could these symmetric checks (crossroads/elemental) be moved from incompatible1() to incompatible()?

@emmiegit
Copy link
Contributor Author

I see, incompatible() is the wrapper. You're suggesting moving it because the symmetry means additional checks are being performed that are not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants