[#1207] remove common-lang3 and update qulice

pom.xml

@@ -177,11 +177,6 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
       <artifactId>lombok</artifactId>
       <version>1.18.30</version>
     </dependency>
-    <dependency>
-      <groupId>org.apache.commons</groupId>
-      <artifactId>commons-lang3</artifactId>
-      <version>3.14.0</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-text</artifactId>
@@ -833,13 +828,22 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
-            <version>0.22.0</version>
+            <version>0.22.1</version>
             <configuration>
               <excludes combine.children="append">
                 <exclude>checkstyle:/src/main/js/.*</exclude>
                 <exclude>checkstyle:/src/main/scss/.*</exclude>
+                <exclude>checkstyle:/src/main/xsl/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/web/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/agents/daemons/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/agents/docker/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/agents/github/qtn/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/agents/req/.*</exclude>
+                <exclude>checkstyle:/src/main/resources/com/rultor/spi/upgrade/.*</exclude>
+                <exclude>checkstyle:/src/site/.*</exclude>
                 <exclude>checkstyle:/src/jekyll/guard-article.pdf</exclude>
                 <exclude>checkstyle:/src/jekyll/images/.*</exclude>
+                <exclude>checkstyle:/src/jekyll/favicon.ico</exclude>
                 <exclude>findbugs:.*</exclude>
                 <exclude>duplicatefinder:.*</exclude>
               </excludes>

src/jekyll/_layouts/default.html

@@ -7,7 +7,8 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0"/>
     <link rel="icon" type="image/png" href="//img.rultor.com/logo-128x128.png">
     <link rel="shortcut icon" href="//img.rultor.com/logo-128x128.png" />
-    <link rel="alternate" type="application/rss+xml" title="RSS" href="http://doc.thindeck.com/rss.xml"/>
+    <link rel="alternate" type="application/rss+xml" title="RSS"
+      href="http://doc.thindeck.com/rss.xml"/>
     <link rel="author" href="//plus.google.com/u/0/114792568016408327418?rel=author" />
     <link rel="stylesheet" href="/css/layout.css?{{ site.data['hash'] }}"/>
     <link rel="canonical" href="//doc.rultor.com{{ page.url }}" />
@@ -79,7 +80,9 @@ <h1 itemprop="headline">{{ page.title }}</h1>
           </div>
         </div>
         <p>
-          <a href="https://github.com/yegor256/rultor/commit/{{ site.data['hash'] }}">{{ site.data['hash'] }}</a>
+          <a href="https://github.com/yegor256/rultor/commit/{{ site.data['hash'] }}">
+            {{ site.data['hash'] }}
+          </a>
         </p>
       </footer>
     </div>
@@ -99,7 +102,8 @@ <h1 itemprop="headline">{{ page.title }}</h1>
       f = function () { n.parentNode.insertBefore(s, n); };
       s.type = "text/javascript";
       s.async = true;
-      s.src = (d.location.protocol == "https:" ? "https:" : "http:") + "//mc.yandex.ru/metrika/watch.js";
+      s.src = (d.location.protocol == "https:" ? "https:" : "http:") +
+        "//mc.yandex.ru/metrika/watch.js";
       if (w.opera == "[object Opera]") {
       d.addEventListener("DOMContentLoaded", f, false);
       } else { f(); }

src/jekyll/_posts/2014/jul/2014-07-13-basics.md

@@ -115,7 +115,9 @@ Then, in your script you get `$tag` environment variable,
 which will be set to `1.7`. Your script should change
 the version of the product to 1.7 and build it.
 
-This is how we do it in jcabi [`rultor.yml`](https://github.com/jcabi/jcabi/blob/master/.rultor.yml). For example:
+This is how we do it in jcabi
+[`rultor.yml`](https://github.com/jcabi/jcabi/blob/master/.rultor.yml).
+For example:
 
 {% highlight yaml %}
 release:

src/jekyll/_posts/2014/jul/2014-07-13-reference.md

@@ -295,7 +295,8 @@ release:
     echo "packaging..."
 {% endhighlight %}
 
-`sensitive` option lists files that must not present in the branch after the release. It is recommended to list your sensitive config files there.
+`sensitive` option lists files that must not present in the branch after the release.
+It is recommended to list your sensitive config files there.
 
 `pre` option if set to `false` will automatically mark the release in GitHub as "final."
 

src/main/java/com/rultor/agents/github/Answer.java

@@ -44,10 +44,11 @@
 import java.util.TreeSet;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
-import org.apache.commons.lang3.StringUtils;
 import org.cactoos.iterable.Mapped;
 import org.cactoos.iterable.Reversed;
 import org.cactoos.list.ListOf;
+import org.cactoos.text.Abbreviated;
+import org.cactoos.text.FormattedText;
 import org.cactoos.text.Joined;
 import org.cactoos.text.UncheckedText;
 import org.xembly.Xembler;
@@ -133,16 +134,16 @@ private String msg(final boolean success, final String text) {
         final StringBuilder msg = new StringBuilder(100);
         try {
             msg.append(
-                String.format(
+                new FormattedText(
                     "> %s\n\n",
-                    StringUtils.abbreviate(
+                    new Abbreviated(
                         this.comment.body().replaceAll(
                             "\\p{Space}",
                             Answer.SPACE
                         ),
                         100
                     )
-                )
+                ).asString()
             );
             final Collection<String> logins = new TreeSet<>();
             logins.add(this.comment.author().login());

src/main/java/com/rultor/agents/github/Understands.java

@@ -47,7 +47,6 @@
 import java.util.ResourceBundle;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
-import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.cactoos.iterable.Joined;
 import org.xembly.Directive;
 import org.xembly.Directives;
@@ -60,14 +59,13 @@
 @Immutable
 @ToString
 @EqualsAndHashCode(callSuper = false, of = { "github", "question" })
-@SuppressWarnings
-    (
-        {
-            "PMD.CyclomaticComplexity",
-            "PMD.StdCyclomaticComplexity",
-            "PMD.ModifiedCyclomaticComplexity"
-        }
-    )
+@SuppressWarnings(
+    {
+    "PMD.CyclomaticComplexity",
+    "PMD.StdCyclomaticComplexity",
+    "PMD.ModifiedCyclomaticComplexity"
+    }
+)
 public final class Understands extends AbstractAgent {
 
     /**
@@ -200,7 +198,7 @@ private Req parse(final Comment.Smart comment, final XML xml)
                 false,
                 String.format(
                     Understands.PHRASES.getString("Understands.broken-profile"),
-                    ExceptionUtils.getRootCauseMessage(ex)
+                    Understands.rootCause(ex)
                 )
             );
             req = Req.EMPTY;
@@ -225,4 +223,16 @@ private static int seen(final XML xml) {
         return seen;
     }
 
+    /**
+     * Root cause exception message.
+     * @param exception Error
+     * @return Message
+     */
+    private static String rootCause(final Profile.ConfigException exception) {
+        Throwable root = exception;
+        while (!root.equals(root.getCause())) {
+            root = root.getCause();
+        }
+        return root.getMessage();
+    }
 }

src/main/java/com/rultor/agents/github/qtn/QnLock.java

@@ -50,10 +50,11 @@
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
 import org.apache.commons.codec.binary.Base64;
-import org.apache.commons.lang3.StringUtils;
 import org.cactoos.iterable.Mapped;
 import org.cactoos.list.ListOf;
 import org.cactoos.text.Joined;
+import org.cactoos.text.Replaced;
+import org.cactoos.text.TextOf;
 import org.cactoos.text.UncheckedText;
 import org.xembly.Directives;
 import org.xembly.Xembler;
@@ -95,10 +96,10 @@ public Req understand(final Comment.Smart comment,
             users.addAll(
                 new ListOf<>(
                     new Mapped<>(
-                        input -> StringUtils.stripStart(
-                            input.trim().toLowerCase(Locale.ENGLISH),
-                            "@"
-                        ),
+                        input -> new Replaced(
+                            new TextOf(input.trim().toLowerCase(Locale.ENGLISH)),
+                            "^@", ""
+                        ).asString(),
                         Arrays.asList(
                             args.xpath(
                                 "//arg[@name='users']/text()"

src/main/java/com/rultor/agents/req/DockerRun.java

@@ -33,7 +33,6 @@
 import com.jcabi.xml.XML;
 import com.rultor.spi.Profile;
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.LinkedList;
@@ -42,11 +41,12 @@
 import java.util.Map.Entry;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
-import org.apache.commons.lang3.StringUtils;
 import org.cactoos.iterable.Joined;
 import org.cactoos.iterable.Mapped;
 import org.cactoos.iterable.Sticky;
 import org.cactoos.list.ListOf;
+import org.cactoos.text.Split;
+import org.cactoos.text.Trimmed;
 
 /**
  * Docker run command.
@@ -176,8 +176,9 @@ private static Iterable<String> scripts(final XML xml, final String path) {
      * @return If hash is in quotes.
      */
     private static boolean inquotes(final String item, final int pos) {
-        return StringUtils.countMatches(item.substring(0, pos), "\"") % 2 == 1
-            || StringUtils.countMatches(item.substring(0, pos), "'") % 2 == 1;
+        final String sub = item.substring(0, pos);
+        return sub.chars().filter(c -> c == '"').count() % 2 == 1
+            || sub.chars().filter(c -> c == '\'').count() % 2 == 1;
     }
 
     /**
@@ -250,10 +251,8 @@ private static Collection<String> lines(final XML node) {
             lines.addAll(
                 new ListOf<>(
                     new Mapped<>(
-                        String::trim,
-                        Arrays.asList(
-                            StringUtils.split(node.xpath("text()").get(0), '\n')
-                        )
+                        t -> new Trimmed(t).asString(),
+                        new Split(node.xpath("text()").get(0), "\n")
                     )
                 )
             );

src/main/java/com/rultor/agents/shells/SmartHost.java

@@ -42,7 +42,7 @@
  */
 @Immutable
 @ToString
-@EqualsAndHashCode(of = { "host" })
+@EqualsAndHashCode(of = "host")
 @SuppressWarnings({"PMD.ShortMethodName",
     "PMD.ConstructorOnlyInitializesOrCallOtherConstructors"})
 final class SmartHost {

src/main/java/com/rultor/web/TkAppFallback.java

@@ -33,7 +33,6 @@
 import io.sentry.Sentry;
 import java.io.IOException;
 import java.net.HttpURLConnection;
-import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.takes.Response;
 import org.takes.Take;
 import org.takes.facets.fallback.FbChain;
@@ -105,7 +104,7 @@ private static Response fatal(final RqFallback req) throws IOException {
                     TkAppFallback.class.getResource("error.html.vm"),
                     new RsVelocity.Pair(
                         "err",
-                        ExceptionUtils.getStackTrace(req.throwable())
+                        req.throwable().getStackTrace()
                     ),
                     new RsVelocity.Pair("rev", TkAppFallback.REV)
                 ),

src/main/resources/com/rultor/agents/github/qtn/status.xsl

@@ -133,7 +133,8 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
     <xsl:variable name="seconds" select="60"/>
     <!--
         <xsl:variable name="seconds"
-            select="number((current-dateTime() - xs:dateTime($time)) div xs:dayTimeDuration('PT1S'))"/>
+            select=
+            "number((current-dateTime() - xs:dateTime($time)) div xs:dayTimeDuration('PT1S'))"/>
         -->
     <xsl:choose>
       <xsl:when test="$seconds &gt; 60 * 60">