New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1207] remove common-lang3 and update qulice #1920
Conversation
@yegor256 please take a look |
@@ -105,7 +104,7 @@ private static Response fatal(final RqFallback req) throws IOException { | |||
TkAppFallback.class.getResource("error.html.vm"), | |||
new RsVelocity.Pair( | |||
"err", | |||
ExceptionUtils.getStackTrace(req.throwable()) | |||
req.throwable().getStackTrace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnatashap I believe, this is not exactly what ExceptionUtils.getStackTrace
does. We should use Logger.format("%[exception]s", req.throwable())
instead.
@pnatashap looks great! one small comment above |
@yegor256 fixed |
@rultor merge |
@pnatashap thanks a lot! |
includes #1915