Created a unique names test (Issue #234) #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegor256
reviewed
Apr 1, 2024
tests/steps/test-unique.sh
Outdated
| $("${LOCAL}/steps/measure-file.sh" "${java}" "${temp}/m1") | ||
| set -x | ||
| all=$(find "${temp}" -name 'm1.*' -type f -exec basename {} \; | sort) | ||
| expected=52 |
There was a problem hiding this comment.
@MoromugHSE it's a typo, I believe? The expected should be counted, not be a constant?
|
@MoromugHSE try to run |
…rding to linter demands.
|
@MoromugHSE did you run |
Has just run it again (in docker) -- all tests pass locally, yet test-unique.sh is somehow not executable for the workflows. |
|
@MoromugHSE please, read this: https://www.yegor256.com/2024/04/01/ping-me-please.html I keep missing your messages, that's why delays |
|
@yegor256 finally found the command for GitHub to acknowledge the exec permission -- rather surprised how much time did it take to even think about looking for it... |
|
@MoromugHSE thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a test suggested by issue #234, checking that we have no conflicting metric names.