Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need a test to check that we no conflicting names of metrics #234

Closed
yegor256 opened this issue Mar 21, 2024 · 1 comment
Closed

need a test to check that we no conflicting names of metrics #234

yegor256 opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yegor256
Copy link
Owner

Let's create a test that will run all scripts in the metrics/ directory, collect their outputs and make sure we have only unique names. We do this in report.sh, but we don't test their uniqueness there. Let's create a unit test for this.
@yegor256 yegor256 added enhancement New feature or request help wanted Extra attention is needed labels Mar 21, 2024
@MoromugHSE MoromugHSE mentioned this issue Apr 1, 2024
Merged
@MoromugHSE
Copy link
Contributor

Seems to be ready for merging -- check pull-request #262, please!

yegor256 added a commit that referenced this issue Apr 2, 2024
@yegor256
Merge pull request #262 from MoromugHSE/test-unique
61d4bcd 
Created a unique names test (Issue #234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yegor256 @MoromugHSE