Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing cast to hash in repo discovery script #212

Merged
merged 8 commits into from Mar 20, 2024
Merged

Fix missing cast to hash in repo discovery script #212

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15c4de1
[#211] Fix missing cast to hash in repo discovery script
howcanunot Mar 17, 2024
430a73f
install tlmgr util if necessary
howcanunot Mar 18, 2024
e9e700c
Revert "install tlmgr util if necessary"
howcanunot Mar 18, 2024
d585d9a
extra test for discovery repos script
howcanunot Mar 18, 2024
5e26341
codestyle
howcanunot Mar 18, 2024
a99aaa7
misspell
howcanunot Mar 18, 2024
0c149f9
remove debug log
howcanunot Mar 20, 2024
4ebcb9e
missing cast
howcanunot Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions steps/discover-repos.rb
View file
Open in desktop
Expand Up @@ -75,10 +75,11 @@
break
end
json = if opts[:dry]
{ items: page > 100 ? [] : [{ full_name: "foo/#{Random.hex(5)}", created_at: Time.now }] }
{ items: page > 100 ? [] : Array.new(size) { { full_name: "foo/#{Random.hex(5)}", created_at: Time.now } } }
else
github.search_repositories(query, per_page: size, page: page)
end
puts(json)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howcanunot this is a debug output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch..
yeap, I'll remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
thanks!

json[:items].each do |i|
found[i[:full_name]] = {
full_name: i[:full_name],
Expand All @@ -102,7 +103,7 @@
puts "Found #{found.count} total repositories in GitHub"

if found.count > opts[:total]
found = found.first(opts[:total])
found = found.first(opts[:total]).to_h
puts "We will use only the first #{opts[:total]} repositories"
end

Expand Down
16 changes: 14 additions & 2 deletions tests/steps/test-discover-repos.sh
View file
Open in desktop
Expand Up @@ -30,12 +30,24 @@ tex=${TARGET}/foo.tex

{
rm -f "${csv}"
msg=$("${LOCAL}/steps/discover-repos.rb" --dry --pause=0 --total=3 --min-stars=100 --max-stars=1000 "--csv=${csv}" "--tex=${tex}")
msg=$("${LOCAL}/steps/discover-repos.rb" --dry --pause=0 --total=3 --page-size=1 --min-stars=100 --max-stars=1000 "--csv=${csv}" "--tex=${tex}")
echo "${msg}"
echo "${msg}" | grep "Found 1 repositories in page #0"
echo "${msg}" | grep "Found 3 total repositories in GitHub"
test -e "${csv}"
test -s "${tex}"
test "$(wc -l < "${csv}" | xargs)" = '4'
} > "${stdout}" 2>&1
echo "👍🏻 A few repositories discovered correctly"
echo "👍🏻 Small repositories discovery test is succeed"

{
rm -f "${csv}"
msg=$("${LOCAL}/steps/discover-repos.rb" --dry --pause=0 --total=35 --page-size=30 --min-stars=100 --max-stars=1000 "--csv=${csv}" "--tex=${tex}")
echo "${msg}"
echo "${msg}" | grep "Found 60 total repositories in GitHub"
echo "${msg}" | grep "We will use only the first 35 repositories"
test -e "${csv}"
test -s "${tex}"
test "$(wc -l < "${csv}" | xargs)" = '36'
} > "${stdout}" 2>&1
echo "👍🏻 Medium repositories discovery test is succeed"