Fix missing cast to hash in repo discovery script

[howcanunot]

Fix this exception in discovery-repos.rb script

cam/steps/discover-repos.rb:125:in `<main>': undefined method `values' for an instance of Array (NoMethodError)
lines = [found.first[1].keys.join(',')] + found.values.map { |m| m.values.join(',') }
Did you mean?  values_at

#211

[yegor256]

@howcanunot thanks for the fix! Would be great to supplement the fix with a unit test. Otherwise, how do we know anything was fixed?

[howcanunot]

@howcanunot thanks for the fix! Would be great to supplement the fix with a unit test. Otherwise, how do we know anything was fixed?

What is the best way to add such a test? Would it be enough to add extra case to tests/steps/test-discover-repos.sh?

[yegor256]

@howcanunot yes, most probably this will be enough. In general, before fixing code, try to reproduce the bug in a test. You should run make test and it should fail. Then, you fix the code and the test passes. Only then you make a pull request.

[howcanunot]

some changes in commit:

• in dry_run script mode we should get not only single repo but page-size for every iteration, just like in normal mode
• extra test to verify that we were able to grep a sufficiently large number of repos

make test TEST=tests/steps/test-discover-repos.sh without fix:

cam/steps/discover-repos.rb:124:in `<main>': undefined method `values' for an instance of Array (NoMethodError)

lines = [found.first[1].keys.join(',')] + found.values.map { |m| m.values.join(',') }
                                               ^^^^^^^
Did you mean?  values_at
❌ Non-zero exit code (TARGET=cam/test-zone/steps/test-discover-repos.sh/target)

[howcanunot]

@yegor256 Good afternoon! Can you please check this pr?

[yegor256]

@howcanunot this is a debug output?

[howcanunot]

ouch..
yeap, I'll remove it.

[howcanunot]

done
thanks!

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 17min)