New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Off The Record #866
base: master
Are you sure you want to change the base?
Conversation
Insert button to conversation head that displays whether history is on or off for conversation. Allow this button to toggle otr status for the conversation
each time otr status is modified, the conversation shows up as a different “group” of messages
Add a banner in conversation to replicate hangouts behavior that notifies who turned history on/off. Change color of conversation bubbles depending on history being on or off
Great work on this!! I really like the hangouts-style notification of the otr status!! 👍 There is just a scenario that I'm not 100% happy with, but this is mostly from my code and not related to yours.
I think this happens when the call to I'm currently on a bad internet connection, so this might be specific to me. Do you ever experience this? ps. It does not matter if in first step I am turning history on or off. Used off to follow through on use case. |
@averissimo I may have seen that at some time, but I've been trying to replicate it and I don't get that behavior. What does happen to me is that, I toggle the history button, and the amount of time it takes for the banner to show up saying I turned history on or off varies. Sometimes it's really short (almost instantaneous, but not quite), and other times it takes a few seconds. I'm sure it has to do with the time it takes to sync. |
yeah, I was trying to work around this with ( 3c43b0b ), by calling history as soon as a callback for (note: calling history and changing the way it was merged to avoid duplicate entries and out of order messages) But my internet connection is pretty bad now and I can't even send messages most of the time -_- |
@averissimo What do you think about something like this pago88@b85ec5d5fe422ff511df2e884e84c9ebe1c48a94 that I was testing . It simply tells the client to sync as soon as the client successfully toggles the otr status. In my testing it takes about 1 - 2 seconds every time to receive the notification about the otr change. |
Adds a button to the conversation head that can toggle the conversation's history status. It will display whether the conversation's history is currently on or off.
When an otr modification event is sent/received, it will display a little banner in the conversation displaying who changed history on or off.
Added some styling to change the background color of the the conversation bubbles when history is off (to mimic gmail/hangouts behavior).