Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Snap Support #752

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added Snap Support #752

wants to merge 5 commits into from

Conversation

CmdrNorthpaw
Copy link

YakYak is great, but for some reason you guys neglected the packaging process, other than for Macs with Homebrew. I have in part solved this problem, by using Ubuntu's Snappy process. YakYak is now packaged for Ubuntu Trusty, Ubuntu Xenial and up, Gentoo, Fedora, Debian, openSUSE, Arch Linux, OpenEmbedded, Yocto, OpenWRT and Solus. I did see NPM throwing some errors, but I'm not experienced with it so I don't know what they mean or how to fix them. Oh, I didn't register the name with the Snap store because I knew the name would be associated with my Ubuntu One account. To register the name "yakyak", do this:
sudo apt install snapcraft snapcraft register yakyak
I hope this new integration allows more people to enjoy YakYak more easily.

@CmdrNorthpaw
Copy link
Author

Oh, and if you need help with publishing, check out the Ubuntu Tutorial

@davibe
Copy link
Contributor

davibe commented Sep 15, 2017

@averissimo this is a linux thing so it's yours ! :) can it be integrated in our CI releases or something like that ? I don't want to manually manage releases

@CmdrNorthpaw
Copy link
Author

Thanks for finally getting back, devs! I would also like to see a .desktop file added. I'd do it myself only I wouldn't know where to put it.

@averissimo
Copy link
Member

averissimo commented Sep 15, 2017

@OctoPenguin great work with this, snaps are really nice in linux environments to have nicely encapsulated apps :)

as davibe said, manually managing releases is a big pain and something we've been moving away by using electron-packager and Travis-CI to build everything

Two questions:

  • Are all those files really necessary or can they be downloaded in runtime?
  • Have you looked at electron-builder instead to perform the snap packaging?

@davibe what's the protocol to register in these repositories? personal mail, you create the login credentials for yakyak to use, we use a central yakyak email, something else...

@CmdrNorthpaw
Copy link
Author

CmdrNorthpaw commented Sep 16, 2017

@averissimo I don't know about their necessity. I ran snapcraft with the nodejs plugin, and I haven't managed to get my get my head around NPM's trees, of which there were many. I thought the plugin was needed because the majority of YakYak is written in Node.JS

@Yan-Solo
Copy link

Hi, I'm new to all this. I've used Linux for quite some time but I am trying to get into programming and scripting.

I am currently trying to write a script that configures a new Linux install for me.
The only thing left to do for the script is install YakYak as it is a have to have program for me.

Is there any update on this or how can I find this in snap? Snap find yakyak isn't working for me.

Thanks in advance and keep up the awesome work

@om26er
Copy link

om26er commented Oct 25, 2017

I think there is something really wrong with that PR. You only need a snapcraft yaml build config file and this one seems to include a whole ton of extra things.

@LyzardKing
Copy link

@OctoPenguin You added to the commit the folders created by the snapcraft command.
You need to remove them from the commit,
then you could (just to be safe ;) ) add this to the .gitignore file:

# Snap
parts/
stage/
prime/
*.snap

@CmdrNorthpaw
Copy link
Author

@om26er Well, what I did was as well as creating a Snapcraft config file, I packaged the whole thing. I'm not sure whether or not I should have done that.

@LyzardKing
Copy link

Only the yaml file and any other not created by snapcraft need to be added to the repo.

@CmdrNorthpaw
Copy link
Author

@LyzardKing Right, got it. I'll update my fork.

@CmdrNorthpaw
Copy link
Author

As you can see, I've been doing some work. The fork has been updated, and now only contains a snapcraft.yaml file, which is inside the snap folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants