fix again the RTL problem #1157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i assume this is the correct way to do. please release it again and i will test it thank you again. i apriciate that!
averissimo
requested changes
May 6, 2020
| @@ -246,8 +246,7 @@ drawMessage = (e, entity) -> | |||
| mclz = ['message'] | |||
| mclz.push c for c in MESSAGE_CLASSES when e[c]? | |||
| title = if e.timestamp then moment(e.timestamp / 1000).calendar() else null | |||
| div id:e.event_id, key:e.event_id, class:mclz.join(' '), title:title, | |||
| dir: 'auto', -> | |||
| div id:e.event_id, key:e.event_id, class:mclz.join(' '), title:title, dir: 'auto' -> | |||
There was a problem hiding this comment.
This is not correct, the -> is an argument for div function
You can build it on your own computer by installing nodejs
Then it's as easy as:
- download and extract the repository to a folder
- running in the command line (inside de folder):
npm install
npm start
``
There was a problem hiding this comment.
ok i'll try it
thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i assume this is the correct way to do.
please release it again
and i will test it
thank you again. i apriciate that!