Skip to content

Commit

Permalink
Merge pull request #1161 from mattrjk/fix-macos-new-convo-shortcut
Browse files Browse the repository at this point in the history 
Changed new coversation shortcut for MacOS to Cmd+N
  • Loading branch information
@averissimo
averissimo committed May 8, 2020
2 parents 711fe99 + c872c64 commit 7e8411b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/views/menu.coffee
View file
Expand Up @@ -26,7 +26,7 @@ acceleratorMap = {
# Platform specific
previousconversation: { default: 'Ctrl+K', darwin:'Ctrl+Shift+Tab' }
nextconversation: { default: 'Ctrl+J', darwin:'Ctrl+Tab' }
newconversation: { default: 'CmdOrCtrl+M' }
newconversation: { default: 'CmdOrCtrl+N' }
conversation1: { default: 'Alt+1', darwin:'Command+1' }
conversation2: { default: 'Alt+2', darwin:'Command+2' }
conversation3: { default: 'Alt+3', darwin:'Command+3' }
Expand Down

6 comments on commit 7e8411b

@jeffbyrnes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averissimo curious, why the rolling 1.5.7, instead of just issuing new patch versions (e.g., 1.5.8, 1.5.9, 1.5.10, etc.)?

@averissimo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we release a new patch version we always have a pre-release that is continuously updated.. instead of having beta1, beta2, beta3...

This made sense when yakyak was more actively developed

@jeffbyrnes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I guess for me, it’s… fine to just issue those as actual patch versions? Might simplify things, since YakYak is a bit less active these days.

But no judgment; you do you! I was curious b/c it‘s not a pattern I’ve seen elsewhere (though I am sure it exists).

@averissimo
Copy link
Member Author

@averissimo averissimo commented on 7e8411b Jun 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't stay in v1.5.7 forever... when that patch version is released*(as it was today)*, we move on to the next patch/minor/major version. Creating it first as a rolling release for users to test.

@jeffbyrnes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh, gotcha.

@jeffbyrnes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to explain!

Please sign in to comment.