Generate Custom Model - Support for 4-channel nodes (work-in-progress) #3706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi xLights devs! Huge fan here, and hoping to contribute!
I picked up some "Twinkly RGB+W" 600 string on clearance, and wanted to generate a custom model in xLights similar to what Twinkly does themselves with their app. I found that this would not work out-of-the-box with xLights, as the code seems to assume the controller accepts RGB (3-channel) input.
I hacked up some code and got it to work with the RGB+W lights, so I think I would like to contribute this to the community. I am seeking guidance on how to rewrite it to be most useful.
Rather than just a simple 3-channel/4-channel selector (which does not appropriately distinguish WRGB vs. RGBW nodes), my intuition is that the "color order" drop-down with RGB/GRB...WRGB/WGRB...RGBW.. would be more universally useful for various situations (perhaps with even a mode for single-color (white only) addressable nodes?). I did not see something obvious I should re-use in the code to do this (color order list), but am happy to do whatever works best for the project and the community.
TL;DR: Want to contribute 4-channel support to "generate custom model", seeking advise on how to finalize this contribution for acceptance.
No rush to respond, just hoping for some guidance. Cheers!
Tom Buaas