Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Custom Model - Support for color order and 4-channel nodes #3724

Open
tbuaas opened this issue Feb 11, 2023 · 0 comments
Open

Generate Custom Model - Support for color order and 4-channel nodes #3724

tbuaas opened this issue Feb 11, 2023 · 0 comments

Comments

@tbuaas
Copy link

tbuaas commented Feb 11, 2023

Is your feature request related to a problem? Please describe.
Enhance the "Generate Custom Model" feature to support more node types than 3-channel RGB, such as GRB, WRGB, etc.

Describe the solution you'd like
It would be nice to be able to select the types of nodes being used to generate the color pattern for generating custom models. For example, with my new Twinkly String 600 RGB+W lights, the controller cannot be programmed to accept just 3-channel RGB (to my knowledge), so 4-channel nodes have to be supported to enable this neat feature on Twinkly RGB+W lights (among others, no doubt).

Describe alternatives you've considered
I tried using the slower "Nodes - Manual" mode of Generate Custom Models, but it activated 3 channels at a time in 3-channel increments, which is misaligned with 4-channel nodes, and lights up two nodes at once, etc. I hacked up the code in PR #3706 (just a hack), and got it to work. I would like to rewrite these code changes in a more useful way that could be a contribution to the project, and am seeking guidance from a core developer.

Additional context
I was hoping for some guidance with regard to the best way to re-use existing code that references color order and node types. It would be a shame to duplicate the code in more than once place for what feels like could be a core enumeration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant